Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1190413003: Add black and white constants to theme's colors. (Closed)

Created:
5 years, 6 months ago by tonyg
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium, Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add black and white constants to theme's colors. They're in the Material design color palette. This also adds a file-level dart doc comment. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8b96ccff946fe92576f7ffed283a7087a0abd7a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M sky/sdk/lib/theme/colors.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tonyg
5 years, 6 months ago (2015-06-19 18:44:20 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-19 19:03:42 UTC) #3
abarth-chromium
Thanks!
5 years, 6 months ago (2015-06-19 19:03:48 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 6 months ago (2015-06-20 05:01:03 UTC) #7
abarth-chromium
5 years, 6 months ago (2015-06-20 05:13:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b96ccff946fe92576f7ffed283a7087a0abd7a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698