Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(88)

Issue 1190403002: Mark tests as NeedsManualRebase for Harmony Array methods (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mark tests as NeedsManualRebase for Harmony Array methods BUG=502308 R=adamk LOG=Y Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197499

Patch Set 1 #

Patch Set 2 : remove virtual tests #

Patch Set 3 : re-add virtual tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Dan Ehrenberg
4 years, 10 months ago (2015-06-19 17:10:11 UTC) #1
Dan Ehrenberg
On 2015/06/19 17:10:11, littledan wrote: I'm not sure if all of these tests need to ...
4 years, 10 months ago (2015-06-19 17:33:38 UTC) #2
Dan Ehrenberg
On 2015/06/19 17:33:38, littledan wrote: > On 2015/06/19 17:10:11, littledan wrote: > > I'm not ...
4 years, 10 months ago (2015-06-19 18:13:39 UTC) #3
adamk
You'll actually need to keep the virtual tests in there, otherwise they'll start failing. From ...
4 years, 10 months ago (2015-06-19 18:17:03 UTC) #4
adamk
lgtm
4 years, 10 months ago (2015-06-19 18:19:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190403002/40001
4 years, 10 months ago (2015-06-19 18:19:52 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 21:10:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197499

Powered by Google App Engine
This is Rietveld 408576698