Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 1190393004: Sprites correctly handles zPosition (Closed)

Created:
5 years, 6 months ago by viktorl
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Correctly handle touches together with zPosition Renames hitTest to isPointInside Refactor sorting of children in nodes Fixes zPosition in sprites and hides internal methods Adds scaleX / scaleY properties R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/aaea364860765076fe729c3958b949f8a5290407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -31 lines) Patch
M sky/examples/game/lib/node.dart View 5 chunks +66 lines, -26 lines 0 comments Download
M sky/examples/game/lib/node_with_size.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/game/lib/sprite_box.dart View 4 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viktorl
5 years, 6 months ago (2015-06-19 18:14:37 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-19 18:15:32 UTC) #3
viktorl
5 years, 6 months ago (2015-06-19 18:16:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aaea364860765076fe729c3958b949f8a5290407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698