Source/web/PluginPlaceholderImplTest.cpp - Issue 1190303003: CL for perf tryjob on win

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PluginPlaceholderImplTest.cpp

Issue 1190303003: CL for perf tryjob on win (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: CL for perf tryjob on mac Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/PluginPlaceholderImplTest.cpp

diff --git a/Source/web/PluginPlaceholderImplTest.cpp b/Source/web/PluginPlaceholderImplTest.cpp

index 63faf957933dfa8709be713348c970185a7fe909..49d2e3a485532bc347f9ec02d5db34e889a0e881 100644

--- a/Source/web/PluginPlaceholderImplTest.cpp

+++ b/Source/web/PluginPlaceholderImplTest.cpp

@@ -99,8 +99,8 @@ bool isHiddenWithInlineStyle(Element* element)

{

if (!element->inlineStyle())

return false;

- RefPtrWillBeRawPtr<CSSValue> value = element->inlineStyle()->getPropertyCSSValue(CSSPropertyDisplay);

- return value && value->isPrimitiveValue() && toCSSPrimitiveValue(value.get())->getValueID() == CSSValueNone;

+ NullableCSSValue value = element->inlineStyle()->getPropertyCSSValue(CSSPropertyDisplay);

+ return value && value->isPrimitiveValue() && toCSSPrimitiveValue(value)->getValueID() == CSSValueNone;

}

TEST_F(PluginPlaceholderImplTest, Closeable)

« no previous file with comments | « Source/platform/heap/ThreadState.h ('k') | Tools/run-perf-test.cfg » ('j') | no next file with comments »