LayoutTests/screen_orientation/screenorientation-detached-notify-no-crash.html - Issue 1190293002: Have ScreenOrientationController use a timer for async event dispatch again

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/screen_orientation/screenorientation-detached-notify-no-crash.html

Issue 1190293002: Have ScreenOrientationController use a timer for async event dispatch again (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/screen_orientation/resources/iframe-listen-orientation-change-detach.html ('k') | Source/modules/screen_orientation/ScreenOrientationController.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <iframe id=testIframe></iframe>

	7 <script>

	8 var notifyTest = async_test("Test that async event dispatch to detached frame is gracefully handled.");

	9

	10 function changeOrientationAndDetach() {

	11 // Dispatch an orientationchange event; this is handled asynchronously,

	12 // queueing a task/timer to do the actual dispatch.

	13 window.testRunner.setMockScreenOrientation('portrait-secondary');

	14

	15 // Detach the iframe while the event dispatch is in-flight. If

	16 // the screen orientation controller is finalized during the

	17 // detach, the async event dispatch just after will be treated

	18 // like a no-op -- there's no controller to handle the dispatch.

	19 document.body.removeChild(testIframe);

	20 setTimeout(function () { notifyTest.done(); }, 0);

	21 }

	22 notifyTest.step(function () {

	23 var currentType = window.screen.orientation.type;
	mlamouri (slow - plz ping) 2015/06/19 09:54:26 Could you explain the purpose of that line? Could you explain the purpose of that line? sof 2015/06/19 10:57:17 A bit magic looking; isActiveAndVisible() will onl Show quoted text On 2015/06/19 09:54:26, Mounir Lamouri wrote: > Could you explain the purpose of that line? A bit magic looking; isActiveAndVisible() will only return true if ScreenOrientationController's m_orientation has been set. Change notifications aren't sent if it returns false. sof 2015/06/19 10:59:58 Added a comment. Show quoted text On 2015/06/19 10:57:17, sof wrote: > On 2015/06/19 09:54:26, Mounir Lamouri wrote: > > Could you explain the purpose of that line? > > A bit magic looking; isActiveAndVisible() will only return true if > ScreenOrientationController's m_orientation has been set. Change notifications > aren't sent if it returns false. Added a comment.
	24 testIframe.src = "resources/iframe-listen-orientation-change-detach.html";

	25 });

	26 </script>

	27 </body>

	28 </html>

OLD	NEW