Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 1190283002: Make textDistance() in SelectionController not to create a redundant Range object (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make textDistance() in SelectionController not to create a redundant Range object This patch makes |textDisatnce()| in "SelectionController.cpp" not to create a redundant Range object. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/editing/SelectionController.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-19 07:42:21 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-19 07:57:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190283002/1
4 years, 10 months ago (2015-06-19 07:57:56 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 08:26:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197456

Powered by Google App Engine
This is Rietveld 408576698