Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2390)

Unified Diff: Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 1190273002: Ignore builders without result (2nd part) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index 8564e686b1cdb7612095bc20a2a65c5ce4e6dd55..9fc847f51f9b4a4aeb15c4c663e8796eaafa3b8b 100644
--- a/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -347,8 +347,8 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
stderr = self._tool.executive.run_command([self._tool.path()] + verbose_args + args, cwd=self._tool.scm().checkout_root, return_stderr=True)
for line in stderr.splitlines():
_log.warning(line)
- except ScriptError, e:
- _log.error(e)
+ except ScriptError:
+ traceback.print_exc(file=sys.stderr)
def _builders_to_fetch_from(self, builders_to_check):
# This routine returns the subset of builders that will cover all of the baseline search paths
@@ -533,6 +533,8 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
self._run_in_parallel_and_update_scm(self._optimize_baselines(test_prefix_list, options.verbose))
def _suffixes_for_actual_failures(self, test, builder_name, existing_suffixes):
+ if builder_name not in self.builder_data():
+ return set()
actual_results = self.builder_data()[builder_name].actual_results(test)
if not actual_results:
return set()
@@ -868,8 +870,8 @@ class AutoRebaseline(AbstractParallelRebaselineCommand):
tool.executive.run_command(['git', 'pull'])
self._run_git_cl_command(options, ['dcommit', '-f'])
- except Exception as e:
- _log.error(e)
+ except:
+ traceback.print_exc(file=sys.stderr)
finally:
if did_finish:
self._run_git_cl_command(options, ['set_close'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698