Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: pkg/analyzer/lib/src/generated/element.dart

Issue 1190253002: Tweak for FunctionTypeImpl.==. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/element.dart
diff --git a/pkg/analyzer/lib/src/generated/element.dart b/pkg/analyzer/lib/src/generated/element.dart
index 23bbf66a188df2272fdb5cd79ca96f44a106997a..0c939a3d2df40d97f835fa5ff9713ac64236e7f5 100644
--- a/pkg/analyzer/lib/src/generated/element.dart
+++ b/pkg/analyzer/lib/src/generated/element.dart
@@ -4902,12 +4902,12 @@ class FunctionTypeImpl extends TypeImpl implements FunctionType {
return false;
}
FunctionTypeImpl otherType = object as FunctionTypeImpl;
- return TypeImpl.equalArrays(
+ return returnType == otherType.returnType &&
+ TypeImpl.equalArrays(
normalParameterTypes, otherType.normalParameterTypes) &&
TypeImpl.equalArrays(
optionalParameterTypes, otherType.optionalParameterTypes) &&
- _equals(namedParameterTypes, otherType.namedParameterTypes) &&
- returnType == otherType.returnType;
+ _equals(namedParameterTypes, otherType.namedParameterTypes);
}
@override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698