Move (most of) chrome/browser/drive into components/drive/service.

components/drive.gypi

Index: components/drive.gypi
diff --git a/components/drive.gypi b/components/drive.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..14afb4d5505375757ff43548ff6ef14dbb32e2c2
--- /dev/null
+++ b/components/drive.gypi
@@ -0,0 +1,75 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'targets': [
+    {
+      # GN version: //components/drive:drive
+      'target_name': 'drive',
+      'type': 'static_library',
+      'include_dirs': [
+        '..',
+      ],
+      'dependencies': [
+        '../base/base.gyp:base',
+        '../components/components.gyp:invalidation',
+        '../google_apis/google_apis.gyp:google_apis',
+        '../net/net.gyp:net',
+        '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation',
+        '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation_proto_cpp',
+        '../third_party/re2/re2.gyp:re2',

[jochen (gone - plz use gerrit), 2015/06/26 14:50:53]

same here, as long as you include storage and content, you need to depend on it

[Łukasz Anforowicz, 2015/06/26 22:37:23]

Makes sense for both storage and content.  I've made the change.

In the long-term we probably want to get rid of both dependencies.

content/browser/power_save_blocker:
- Weaning off power_save_blocker would ideally be done by
  componentizing power_save_blocker, but this is difficult
  (mostly because of current dependencies of
   content/browser/power_save_blocker_android.cc)
- So for now, we hoped to keep the include of power_save_blocker.h
  in components/drive, but when including components/drive outside
  of the browser binary we would provide a no-op implementation
  of PowerSaveBlocker::Create ("outside of the browser binary"
  = i.e. in the somewhat experimental Dokan-over-Drive4CrOS binary
  that is not related to Chrome in any way)
- I am not sure anymore that our idea is okay.  OTOH, this shouldn't
  block componentization of Drive4CrOS, which should be fine after
  taking the change suggestion from your feedback.
- One way out would to be provide an abstraction specific to
  components/drive (instead of PowerSaveBlocker).  This can
  be generic (i.e. callbacks when uploads start and end) or
  very similar to PowerSaveBlocker.
At any rate, I have to think more about it... :-/

storage/browser/fileapi/file_stream_reader.h:
- AFAIR hashimoto was saying that this can be moved out
  of components/drive.

+      ],
+      'sources': [
+        'drive/drive_api_util.cc',
+        'drive/drive_api_util.h',
+        'drive/drive_app_registry.cc',
+        'drive/drive_app_registry.h',
+        'drive/drive_app_registry_observer.h',
+        'drive/drive_notification_manager.cc',
+        'drive/drive_notification_manager.h',
+        'drive/drive_notification_observer.h',
+        'drive/drive_uploader.cc',
+        'drive/drive_uploader.h',
+        'drive/event_logger.cc',
+        'drive/event_logger.h',
+        'drive/service/drive_api_service.cc',
+        'drive/service/drive_api_service.h',
+        'drive/service/drive_service_interface.cc',
+        'drive/service/drive_service_interface.h',
+      ],
+    },
+
+    {
+      # GN version: //components/drive:test_support
+      'target_name': 'drive_test_support',
+      'type': 'static_library',
+      'include_dirs': [
+        '..',
+      ],
+      'dependencies': [
+        'drive',
+        '../base/base.gyp:base',
+        '../google_apis/google_apis.gyp:google_apis',
+        '../net/net.gyp:net',
+      ],
+      'sources': [
+        "drive/service/dummy_drive_service.cc",
+        "drive/service/dummy_drive_service.h",
+        "drive/service/fake_drive_service.cc",
+        "drive/service/fake_drive_service.h",
+        "drive/service/test_util.cc",
+        "drive/service/test_util.h",
+      ],
+    },
+
+    # TODO(lukasza): drive_unittests target.
+    # Currently tests are built as part of chrome/chrome_tests_unit.gypi.
+    # Drive files that probably should be moved out of chrome_tests_unit.gypi:
+    #   components/drive/service/drive_api_util_unittest.cc
+    #   components/drive/service/drive_app_registry_unittest.cc
+    #   components/drive/service/drive_uploader_unittest.cc
+    #   components/drive/service/event_logger_unittest.cc
+    #   components/drive/service/fake_drive_service_unittest.cc
+  ],
+}