Move (most of) chrome/browser/drive into components/drive/service.

Move (most of) chrome/browser/drive into components/drive.

Note that drive_notification_manager_factory is left behind in
chrome/browser/drive.  This is because it needs to stay dependent on the
browser.  This is okay, because drive_notification_manager_factory is
not needed by drive::FileSystem and other parts of drive libraries that
we want to componentize.

Also note that some things moved to components/drive continue to
have slightly undesirable dependencies:

- Tests are still built and executed as part of the browser test suites.

- drive_uploader.cc depends on content/public/browser/power_save_blocker.h
  This means that to use components/drive outside of the browser,
  users of components/drive have to provide a no-op implementation
  of power_save_blocker.h
  The most desirable approach in the long-term would be to componentize
  power_save_blocker.h.  An alternative would be to continue with
  the state introduced by the current changelist (or to introduce
  drive-specific abstraction similar to power_save_blocker.h, but
  outside of the browser).

- drive_api_util.cc depends on storage/browser/fileapi/file_stream_reader.h
  To get rid of this dependency, it is probably best to move
  FileStreamMd5Digester class closer to the only point of usage
  (c/b/chromeos/extensions/file_manager/private_api_file_system.cc).

Landing via CQ with NOPRESUBMIT=true, because "git cl presubmit" incorrectly
identifies target directory of a dependency (we are depending on
third_party/cacheinvalidation/src/google/cacheinvalidation/types.proto
and including the generated header via google/cacheinvalidation/types.pb.h).
I believe this is a case of crbug.com/448570.  All other presubmit checks
are passing AFAIK:

    $ git cl presubmit
    Running presubmit commit checks ...

    ** Presubmit ERRORS **
    Missing LGTM from OWNERS of dependencies added to DEPS:
        '+google/cacheinvalidation/types.pb.h',

        Presubmit checks took 2.9s to calculate.

Test steps:
1. Verify that things still build via GYP (and unit tests pass).
    $ GYP_DEFINES="use_goma=1 gomadir=... chromeos=1" gclient sync
    $ ninja -C out/Debug -j 150 chrome unit_tests \
                 interactive_ui_tests browser_tests drive
    $ out/Debug/unit_tests

2. Verify that things still builds via GN.
    $ gn gen out/Default --args='target_os="chromeos" use_goma=true'
    $ ninja -C out/Default -j 150 chrome unit_tests \
                 interactive_ui_tests browser_tests components/drive

TEST=Please see "Test steps" above.
BUG=257943, 498951
NOPRESUBMIT=true

Committed: https://crrev.com/8acc4eb18b6919f36413a10718a607f2a34fb8f6
Cr-Commit-Position: refs/heads/master@{#339512}

[Łukasz Anforowicz, 2015-06-19 16:26:34]

Patchset #1 (id:1) has been deleted

[Łukasz Anforowicz, 2015-06-19 16:26:51]

Patchset #1 (id:20001) has been deleted

[Łukasz Anforowicz, 2015-06-19 18:12:31]

Patchset #1 (id:40001) has been deleted

[Łukasz Anforowicz, 2015-06-19 18:46:18]

lukasza@chromium.org changed reviewers:
+ hashimoto@chromium.org

[Łukasz Anforowicz, 2015-06-19 18:46:19]

Ryo, could you please take a look?

[tfarina, 2015-06-19 18:52:37]

You can collapse these three ninja commands in one line:
$ ninja -C out/Debug target1 target2 target3

For gn as well:

$ gn gen out/Default --args='target_os="chromeos"'

[Łukasz Anforowicz, 2015-06-22 19:27:25]

Ryo, could you please take a look?

Thanks for pointing out (offline) that chrome/browser/drive and
chrome/browser/chromeos/drive used to be in a single directory and therefore it
makes sense to merge them back into components/drive (rather than retaining as 2
subprojects - components/drive/service and components/drive/file_system).  Based
on this information and your suggestion, I have flattened components/drive in
the most recent patchset (leaving only DriveServiceInterface-related code under
components/drive/service).

[hashimoto, 2015-06-22 23:16:16]

Almost looking good, but probably it might be better to start with moving a
relatively simple file (e.g. event_logger) to avoid spending too much time
waiting for a number of reviewers on multiple directories?

https://codereview.chromium.org/1190203002/diff/100001/chrome/browser/drive/R...
File chrome/browser/drive/README (right):

https://codereview.chromium.org/1190203002/diff/100001/chrome/browser/drive/R...
chrome/browser/drive/README:2: components/drive/service.  These parts should
probably be moved
nit: It might be nice to add a link to the componentization bug?
(http://crbug.com/257943)

https://codereview.chromium.org/1190203002/diff/100001/chrome/chrome_browser_...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/1190203002/diff/100001/chrome/chrome_browser_...
chrome/chrome_browser_extensions.gypi:1092:
'../components/components.gyp:drive',
Why do we need to do this when we don't make any changes to
chrome_browser_extensions_app_list_sources?

https://codereview.chromium.org/1190203002/diff/100001/components/drive/DEPS
File components/drive/DEPS (right):

https://codereview.chromium.org/1190203002/diff/100001/components/drive/DEPS#...
components/drive/DEPS:15: "+storage/browser/fileapi/file_stream_reader.h"
nit: Probably we can get rid of this rule by splitting FileStreamMd5Digester
from drive_api_util?
It's only used by
c/b/chromeos/extensions/file_manager/private_api_file_system.cc.

https://codereview.chromium.org/1190203002/diff/100001/components/drive/README
File components/drive/README (right):

https://codereview.chromium.org/1190203002/diff/100001/components/drive/READM...
components/drive/README:4: components/drive/file_system]).
nit: I think we can go without this sentence as we'll leave some code (e.g.
DriveIntegrationService) in c/b/chromeos/drive after all.

https://codereview.chromium.org/1190203002/diff/100001/components/drive/drive...
File components/drive/drive_api_util.h (right):

https://codereview.chromium.org/1190203002/diff/100001/components/drive/drive...
components/drive/drive_api_util.h:1: // Copyright 2015 The Chromium Authors. All
rights reserved.
nit: You shouldn't change copyright notice of moved files (i.e. you can use "git
log --follow components/drive/drive_api_util.h" to track the history of
c/b/drive/drive_api_util.h even after this move)
The same goes for other moved files.

[Łukasz Anforowicz, 2015-06-22 23:57:23]

Ryo, could you please take another look?

I think moving a single file wouldn't help much.  I would still have to get
multiple sign-offs in the long-run.

https://codereview.chromium.org/1190203002/diff/100001/chrome/browser/drive/R...
File chrome/browser/drive/README (right):

https://codereview.chromium.org/1190203002/diff/100001/chrome/browser/drive/R...
chrome/browser/drive/README:2: components/drive/service.  These parts should
probably be moved
On 2015/06/22 23:16:15, hashimoto wrote:
> nit: It might be nice to add a link to the componentization bug?
> (http://crbug.com/257943)

Done.

https://codereview.chromium.org/1190203002/diff/100001/chrome/chrome_browser_...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/1190203002/diff/100001/chrome/chrome_browser_...
chrome/chrome_browser_extensions.gypi:1092:
'../components/components.gyp:drive',
On 2015/06/22 23:16:15, hashimoto wrote:
> Why do we need to do this when we don't make any changes to
> chrome_browser_extensions_app_list_sources?

I've added the dependency here, in an attempt to only use
the new drive component where it is actually needed, but
I don't have high confidence that this is correct.
I think you're right - I should have just moved things
inside chrome_browser.gypi.

https://codereview.chromium.org/1190203002/diff/100001/components/drive/DEPS
File components/drive/DEPS (right):

https://codereview.chromium.org/1190203002/diff/100001/components/drive/DEPS#...
components/drive/DEPS:15: "+storage/browser/fileapi/file_stream_reader.h"
On 2015/06/22 23:16:15, hashimoto wrote:
> nit: Probably we can get rid of this rule by splitting FileStreamMd5Digester
> from drive_api_util?
> It's only used by
> c/b/chromeos/extensions/file_manager/private_api_file_system.cc.

Acknowledged.

https://codereview.chromium.org/1190203002/diff/100001/components/drive/README
File components/drive/README (right):

https://codereview.chromium.org/1190203002/diff/100001/components/drive/READM...
components/drive/README:4: components/drive/file_system]).
On 2015/06/22 23:16:15, hashimoto wrote:
> nit: I think we can go without this sentence as we'll leave some code (e.g.
> DriveIntegrationService) in c/b/chromeos/drive after all.

Done.

https://codereview.chromium.org/1190203002/diff/100001/components/drive/drive...
File components/drive/drive_api_util.h (right):

https://codereview.chromium.org/1190203002/diff/100001/components/drive/drive...
components/drive/drive_api_util.h:1: // Copyright 2015 The Chromium Authors. All
rights reserved.
On 2015/06/22 23:16:15, hashimoto wrote:
> nit: You shouldn't change copyright notice of moved files (i.e. you can use
"git
> log --follow components/drive/drive_api_util.h" to track the history of
> c/b/drive/drive_api_util.h even after this move)
> The same goes for other moved files.

Oh, ok.  I misinterpreted the feedback I got in the other CL -
https://codereview.chromium.org/1192493003/diff/100001/chrome/browser/chromeo...

[hashimoto, 2015-06-23 01:11:42]

lgtm, thank you for making a new component directory for drive!

[Łukasz Anforowicz, 2015-06-23 15:36:45]

lukasza@chromium.org changed reviewers:
+ mtomasz@chromium.org

[Łukasz Anforowicz, 2015-06-23 15:36:47]

Tomasz, could you please take a look at:
chrome/browser/chromeos/file_manager,
chrome/browser/chromeos/extensions/file_manager,
chrome/browser/chromeos/fileapi,
chrome/browser/extensions/api/file_system?

[mtomasz, 2015-06-24 02:25:01]

lgtm

[Łukasz Anforowicz, 2015-06-24 16:06:08]

lukasza@chromium.org changed reviewers:
+ kinuko@chromium.org

[Łukasz Anforowicz, 2015-06-24 16:06:10]

lukasza@chromium.org changed reviewers:
+ kinuko@chromium.org

[Łukasz Anforowicz, 2015-06-24 16:06:10]

Kinuko, could you please take a look for\
chrome/browser/sync_file_system,
chrome/browser/ui/webui/sync_file_system_internals?

[Łukasz Anforowicz, 2015-06-24 16:06:11]

Kinuko, could you please take a look for\
chrome/browser/sync_file_system,
chrome/browser/ui/webui/sync_file_system_internals?

[kinuko, 2015-06-25 04:42:12]

On 2015/06/24 16:06:11, Łukasz Anforowicz wrote:
> Kinuko, could you please take a look for\
> chrome/browser/sync_file_system,
> chrome/browser/ui/webui/sync_file_system_internals?

lgtm

[Łukasz Anforowicz, 2015-06-25 16:51:53]

lukasza@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Łukasz Anforowicz, 2015-06-25 16:51:54]

Xiyuan, could you please take a look for chrome/browser/apps/drive?

[xiyuan, 2015-06-25 16:55:04]

c/b/apps/drive LGTM

[Łukasz Anforowicz, 2015-06-25 17:31:39]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2015-06-25 17:31:41]

jochen@, could you please take a look for
    chrome/browser/BUILD.gn
    components/OWNERS
    components/components.gyp
?

Also - let me explain the newly uploaded patchset - I realized that I need to
add drive.gypi-specific owners to components/OWNERS file (I copied the owners
from components/drive/OWNERS which got moved from chrome/browser/drive/OWNERS).

[jochen (gone - plz use gerrit), 2015-06-26 14:50:54]

https://codereview.chromium.org/1190203002/diff/140001/components/drive.gypi
File components/drive.gypi (right):

https://codereview.chromium.org/1190203002/diff/140001/components/drive.gypi#...
components/drive.gypi:21: '../third_party/re2/re2.gyp:re2',
same here, as long as you include storage and content, you need to depend on it

https://codereview.chromium.org/1190203002/diff/140001/components/drive/BUILD.gn
File components/drive/BUILD.gn (right):

https://codereview.chromium.org/1190203002/diff/140001/components/drive/BUILD...
components/drive/BUILD.gn:29: "//third_party/re2:re2",
please add the dependencies on content/browser and storage

https://codereview.chromium.org/1190203002/diff/140001/components/drive/BUILD...
components/drive/BUILD.gn:34: sources = [
should be marked testonly

[Łukasz Anforowicz, 2015-06-26 22:37:23]

jochen, thank you for the feedback.  Could you please take another look?

https://codereview.chromium.org/1190203002/diff/140001/components/drive.gypi
File components/drive.gypi (right):

https://codereview.chromium.org/1190203002/diff/140001/components/drive.gypi#...
components/drive.gypi:21: '../third_party/re2/re2.gyp:re2',
On 2015/06/26 14:50:53, jochen wrote:
> same here, as long as you include storage and content, you need to depend on
it

Makes sense for both storage and content.  I've made the change.

In the long-term we probably want to get rid of both dependencies.

content/browser/power_save_blocker:
- Weaning off power_save_blocker would ideally be done by
  componentizing power_save_blocker, but this is difficult
  (mostly because of current dependencies of
   content/browser/power_save_blocker_android.cc)
- So for now, we hoped to keep the include of power_save_blocker.h
  in components/drive, but when including components/drive outside
  of the browser binary we would provide a no-op implementation
  of PowerSaveBlocker::Create ("outside of the browser binary"
  = i.e. in the somewhat experimental Dokan-over-Drive4CrOS binary
  that is not related to Chrome in any way)
- I am not sure anymore that our idea is okay.  OTOH, this shouldn't
  block componentization of Drive4CrOS, which should be fine after
  taking the change suggestion from your feedback.
- One way out would to be provide an abstraction specific to
  components/drive (instead of PowerSaveBlocker).  This can
  be generic (i.e. callbacks when uploads start and end) or
  very similar to PowerSaveBlocker.
At any rate, I have to think more about it... :-/

storage/browser/fileapi/file_stream_reader.h:
- AFAIR hashimoto was saying that this can be moved out
  of components/drive.

https://codereview.chromium.org/1190203002/diff/140001/components/drive/BUILD.gn
File components/drive/BUILD.gn (right):

https://codereview.chromium.org/1190203002/diff/140001/components/drive/BUILD...
components/drive/BUILD.gn:29: "//third_party/re2:re2",
On 2015/06/26 14:50:53, jochen wrote:
> please add the dependencies on content/browser and storage

Done.  (some more details added in response to the other comment)

https://codereview.chromium.org/1190203002/diff/140001/components/drive/BUILD...
components/drive/BUILD.gn:34: sources = [
On 2015/06/26 14:50:53, jochen wrote:
> should be marked testonly 

Ooops.  Thanks for catching this.  Done.

[jochen (gone - plz use gerrit), 2015-06-30 07:53:10]

lgtm

[Łukasz Anforowicz, 2015-06-30 16:10:31]

lukasza@chromium.org changed reviewers:
+ jam@chromium.org

[Łukasz Anforowicz, 2015-06-30 16:10:32]

jam@, could you please take a look? (mostly at the new chrome/browser/drive/DEPS
and maybe at components/drive/DEPS).

This is what "git cl" told me:
  Missing LGTM from OWNERS of dependencies added to DEPS:
    '+google/cacheinvalidation/types.pb.h',
    '+google_apis',
    '+net',

  Suggested missing target path OWNERS:
    jam@chromium.org

Side note: I believe that DEPS / ownership checking scripts are confused wrt
ownership of
third_party/cacheinvalidation/src/google/cacheinvalidation/types.proto.  I think
this is similar to crbug.com/448570.

[Łukasz Anforowicz, 2015-06-30 17:44:52]

On 2015/06/30 16:10:32, Łukasz Anforowicz wrote:
> jam@, could you please take a look? (mostly at the new
chrome/browser/drive/DEPS
> and maybe at components/drive/DEPS).

Argh... I should more carefully proof-read what I send.  Obviously
components/drive/DEPS is new and probably requires more attention, than the
slightly changed chrome/browser/drive/DEPS.

[mtomasz, 2015-07-08 04:51:54]

On 2015/06/30 17:44:52, Łukasz Anforowicz wrote:
> On 2015/06/30 16:10:32, Łukasz Anforowicz wrote:
> > jam@, could you please take a look? (mostly at the new
> chrome/browser/drive/DEPS
> > and maybe at components/drive/DEPS).
> 
> Argh... I should more carefully proof-read what I send.  Obviously
> components/drive/DEPS is new and probably requires more attention, than the
> slightly changed chrome/browser/drive/DEPS.

Hi Lukasz. Is there anything left to commit this CL? Let me know if you need any
help. Thanks.

[jam, 2015-07-09 16:42:13]

On 2015/06/30 16:10:32, Łukasz Anforowicz wrote:
> jam@, could you please take a look? (mostly at the new
chrome/browser/drive/DEPS
> and maybe at components/drive/DEPS).
> 
> This is what "git cl" told me:
>   Missing LGTM from OWNERS of dependencies added to DEPS:
>     '+google/cacheinvalidation/types.pb.h',
>     '+google_apis',
>     '+net',
> 
>   Suggested missing target path OWNERS:
>     mailto:jam@chromium.org
> 
> Side note: I believe that DEPS / ownership checking scripts are confused wrt
> ownership of
> third_party/cacheinvalidation/src/google/cacheinvalidation/types.proto.  I
think
> this is similar to crbug.com/448570.

Just saw this (was ooo). Please get owners review from those in google/OWNERS,
google_apis/owners, and net/owners (the script just picked me because i'm top
level, but the script really needs to stop doing that).

[Łukasz Anforowicz, 2015-07-09 17:27:42]

lukasza@chromium.org changed reviewers:
+ mef@chromium.org

[Łukasz Anforowicz, 2015-07-09 17:27:44]

Misha, can you please review the components/drive/DEPS -> net dependency? (which
is simply being copied from chrome/browser/drive/DEPS into
components/drive/DEPS).

[mef, 2015-07-09 19:05:36]

On 2015/07/09 17:27:44, Łukasz Anforowicz wrote:
> Misha, can you please review the components/drive/DEPS -> net dependency?
(which
> is simply being copied from chrome/browser/drive/DEPS into
> components/drive/DEPS).

Hrm, I don't see "+net" in current chrome/browser/drive/DEPS, am I missing
something?

[Łukasz Anforowicz, 2015-07-09 19:08:24]

On 2015/07/09 19:05:36, mef wrote:
> On 2015/07/09 17:27:44, Łukasz Anforowicz wrote:
> > Misha, can you please review the components/drive/DEPS -> net dependency?
> (which
> > is simply being copied from chrome/browser/drive/DEPS into
> > components/drive/DEPS).
> 
> Hrm, I don't see "+net" in current chrome/browser/drive/DEPS, am I missing
> something?

chrome/browser/drive/DEPS inherits "+net" from chrome/DEPS.

[mef, 2015-07-09 19:14:43]

On 2015/07/09 19:08:24, Łukasz Anforowicz wrote:
> On 2015/07/09 19:05:36, mef wrote:
> > On 2015/07/09 17:27:44, Łukasz Anforowicz wrote:
> > > Misha, can you please review the components/drive/DEPS -> net dependency?
> > (which
> > > is simply being copied from chrome/browser/drive/DEPS into
> > > components/drive/DEPS).
> > 
> > Hrm, I don't see "+net" in current chrome/browser/drive/DEPS, am I missing
> > something?
> 
> chrome/browser/drive/DEPS inherits "+net" from chrome/DEPS.

Ah, thanks! 
components/drive/DEPS lgtm

[Łukasz Anforowicz, 2015-07-09 20:10:58]

lukasza@chromium.org changed reviewers:
+ rogerta@chromium.org

[Łukasz Anforowicz, 2015-07-09 20:10:59]

Roger, can you please review the components/drive/DEPS -> google_apis
dependency?  (this dependency is simply being copied from
chrome/browser/drive/DEPS into components/drive/DEPS;  note that
"copied" is slightly inaccurate as chrome/browser/drive/DEPS was
previously inheriting "+google_apis" from chrome/browser/DEPS).

[mtomasz, 2015-07-14 01:33:06]

On 2015/07/09 20:10:59, Łukasz Anforowicz wrote:
> Roger, can you please review the components/drive/DEPS -> google_apis
> dependency?  (this dependency is simply being copied from
> chrome/browser/drive/DEPS into components/drive/DEPS;  note that
> "copied" is slightly inaccurate as chrome/browser/drive/DEPS was
> previously inheriting "+google_apis" from chrome/browser/DEPS).

@rogertawa: Friendly ping.

I can't wait to get it committed. It's a great cleanup. Thanks for doing it.

[Roger Tawa OOO till Jul 10th, 2015-07-14 21:48:42]

lgtm google_apis deps

sorry for late response, was away last week and just catching up.

[Łukasz Anforowicz, 2015-07-14 23:59:20]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2015-07-14 23:59:21]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
mtomasz@chromium.org, hashimoto@chromium.org, xiyuan@chromium.org,
jochen@chromium.org, rogerta@chromium.org, mef@chromium.org
Link to the patchset: https://codereview.chromium.org/1190203002/#ps200001
(title: "Rebasing...")

[commit-bot: I haz the power, 2015-07-14 23:59:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190203002/200001

[commit-bot: I haz the power, 2015-07-15 00:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 00:37:07]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Łukasz Anforowicz, 2015-07-15 01:20:39]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2015-07-15 01:21:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190203002/200001

[commit-bot: I haz the power, 2015-07-15 01:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 01:51:27]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[mtomasz, 2015-07-15 06:07:27]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-07-15 06:07:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190203002/200001

[commit-bot: I haz the power, 2015-07-15 06:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 06:52:46]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[mtomasz, 2015-07-16 01:56:56]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-07-16 01:57:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190203002/200001

[commit-bot: I haz the power, 2015-07-16 02:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 02:09:02]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[mtomasz, 2015-07-16 07:25:09]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-07-16 07:25:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190203002/200001

[commit-bot: I haz the power, 2015-07-16 07:58:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 07:58:14]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Łukasz Anforowicz, 2015-07-20 19:53:58]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2015-07-20 19:53:59]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
rogerta@chromium.org, xiyuan@chromium.org, kinuko@chromium.org,
mtomasz@chromium.org, hashimoto@chromium.org, mef@chromium.org
Link to the patchset: https://codereview.chromium.org/1190203002/#ps240001
(title: "Rebasing...")

[commit-bot: I haz the power, 2015-07-20 19:54:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1190203002/240001

[commit-bot: I haz the power, 2015-07-20 20:57:47]

Committed patchset #10 (id:240001)

[commit-bot: I haz the power, 2015-07-20 20:59:01]

Patchset 10 (id:??) landed as
https://crrev.com/8acc4eb18b6919f36413a10718a607f2a34fb8f6
Cr-Commit-Position: refs/heads/master@{#339512}