Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(35)

Issue 1190173003: PartitionAlloc: API changes to support new partitionPurgeMemoryGeneric() mode. (Closed)

Created:
4 years, 10 months ago by Chris Evans
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

PartitionAlloc: API changes to support new partitionPurgeMemoryGeneric() mode. No real functional changes. BUG=501878 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197406

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -25 lines) Patch
M Source/platform/PartitionAllocMemoryDumpProvider.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/wtf/PartitionAlloc.h View 2 chunks +10 lines, -3 lines 0 comments Download
M Source/wtf/PartitionAlloc.cpp View 1 3 chunks +8 lines, -6 lines 0 comments Download
M Source/wtf/PartitionAllocTest.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M Source/wtf/Partitions.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Chris Evans
4 years, 10 months ago (2015-06-18 17:29:57 UTC) #2
haraken
LGTM https://codereview.chromium.org/1190173003/diff/1/Source/wtf/PartitionAlloc.cpp File Source/wtf/PartitionAlloc.cpp (right): https://codereview.chromium.org/1190173003/diff/1/Source/wtf/PartitionAlloc.cpp#newcode912 Source/wtf/PartitionAlloc.cpp:912: partitionDecommitFreePages(root); Nit: We might want to rename this ...
4 years, 10 months ago (2015-06-18 18:00:11 UTC) #3
Chris Evans
On 2015/06/18 18:00:11, haraken wrote: > LGTM > > https://codereview.chromium.org/1190173003/diff/1/Source/wtf/PartitionAlloc.cpp > File Source/wtf/PartitionAlloc.cpp (right): > ...
4 years, 10 months ago (2015-06-18 18:10:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190173003/20001
4 years, 10 months ago (2015-06-18 18:12:58 UTC) #7
haraken
On 2015/06/18 18:10:12, Chris Evans wrote: > On 2015/06/18 18:00:11, haraken wrote: > > LGTM ...
4 years, 10 months ago (2015-06-18 18:16:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59573)
4 years, 10 months ago (2015-06-18 20:28:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190173003/20001
4 years, 10 months ago (2015-06-18 20:30:34 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 22:49:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197406

Powered by Google App Engine
This is Rietveld 408576698