Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 119013004: Revert "More API cleanup." (Closed)

Created:
7 years ago by Sven Panne
Modified:
7 years ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert "More API cleanup." This reverts r18383. The CL in itself is OK, we just have to wait until Chrome's commit queue lands the final corresponding change and re-land this CL. :-/ TBR=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+637 lines, -700 lines) Patch
M include/v8.h View 7 chunks +18 lines, -3 lines 0 comments Download
M src/api.cc View 11 chunks +62 lines, -11 lines 0 comments Download
M src/d8-posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/extensions/statistics-extension.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/cctest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/profiler-extension.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/test-accessors.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 160 chunks +371 lines, -433 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 12 chunks +14 lines, -34 lines 0 comments Download
M test/cctest/test-debug.cc View 38 chunks +58 lines, -79 lines 0 comments Download
M test/cctest/test-declarative-accessors.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M test/cctest/test-decls.cc View 20 chunks +36 lines, -46 lines 0 comments Download
M test/cctest/test-global-handles.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-global-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 5 chunks +8 lines, -13 lines 0 comments Download
M test/cctest/test-object-observe.cc View 8 chunks +30 lines, -35 lines 0 comments Download
M test/cctest/test-strings.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years ago (2013-12-20 11:32:18 UTC) #1
Sven Panne
Committed patchset #1 manually as r18384.
7 years ago (2013-12-20 11:36:10 UTC) #2
Hannes Payer (out of office)
7 years ago (2013-12-20 11:42:21 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698