sky/sdk/lib/widgets/scaffold.dart - Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/scaffold.dart

Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co… (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: j/k -- this one should actually be fully merged and testable Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/widgets/scaffold.dart

diff --git a/sky/sdk/lib/widgets/scaffold.dart b/sky/sdk/lib/widgets/scaffold.dart

index b98b3beef49f8c623419544d659764bae7198d25..e975e516b8419fce60d8eb4dc8cc9aa0cb96fdcb 100644

--- a/sky/sdk/lib/widgets/scaffold.dart

+++ b/sky/sdk/lib/widgets/scaffold.dart

@@ -124,7 +124,7 @@ class RenderScaffold extends RenderBox {

}

- void paint(RenderObjectDisplayList canvas) {

+ void paint(RenderCanvas canvas) {

for (ScaffoldSlots slot in [ScaffoldSlots.body, ScaffoldSlots.statusBar, ScaffoldSlots.toolbar, ScaffoldSlots.floatingActionButton, ScaffoldSlots.drawer]) {

RenderBox box = _slots[slot];

if (box != null) {

« sky/sdk/lib/rendering/box.dart ('K') | « sky/sdk/lib/widgets/ink_well.dart ('k') | sky/tests/examples/sector-expected.txt » ('j') | sky/tests/resources/display_list.dart » ('J')