Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: sky/examples/game/lib/node.dart

Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co… (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rebased version of previous patch Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/examples/game/lib/node.dart
diff --git a/sky/examples/game/lib/node.dart b/sky/examples/game/lib/node.dart
index ef6162be53d843681e4ed848523c412fbfe793fd..cfb5eab2a571c3bacddcf7456401e186f3288779 100644
--- a/sky/examples/game/lib/node.dart
+++ b/sky/examples/game/lib/node.dart
@@ -395,7 +395,7 @@ class Node {
// Rendering
- void _visit(PictureRecorder canvas) {
+ void _visit(RenderCanvas canvas) {
assert(canvas != null);
if (!visible) return;
@@ -404,7 +404,7 @@ class Node {
_postPaint(canvas);
}
- void _prePaint(PictureRecorder canvas) {
+ void _prePaint(RenderCanvas canvas) {
canvas.save();
// Get the transformation matrix and apply transform
@@ -419,7 +419,7 @@ class Node {
/// bounding box's origin, override [NodeWithSize] and call the applyTransformForPivot method before making calls for
/// drawing.
///
- /// void paint(PictureRecorder canvas) {
+ /// void paint(RenderCanvas canvas) {
/// canvas.save();
/// applyTransformForPivot(canvas);
///
@@ -427,10 +427,10 @@ class Node {
///
/// canvas.restore();
/// }
- void paint(PictureRecorder canvas) {
+ void paint(RenderCanvas canvas) {
}
- void _visitChildren(PictureRecorder canvas) {
+ void _visitChildren(RenderCanvas canvas) {
// Sort children if needed
_sortChildren();
@@ -455,7 +455,7 @@ class Node {
}
}
- void _postPaint(PictureRecorder canvas) {
+ void _postPaint(RenderCanvas canvas) {
canvas.restore();
}

Powered by Google App Engine
This is Rietveld 408576698