sky/sdk/lib/framework/widgets/ink_well.dart - Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/widgets/ink_well.dart

Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co… (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sky/sdk/lib/framework/rendering/stack.dart ('K') | « sky/sdk/lib/framework/rendering/stack.dart ('k') | sky/sdk/lib/framework/widgets/scaffold.dart » ('j') | sky/tests/resources/display_list.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/sdk/lib/framework/widgets/ink_well.dart

diff --git a/sky/sdk/lib/framework/widgets/ink_well.dart b/sky/sdk/lib/framework/widgets/ink_well.dart

index 48188f52a93897b1827a7a7cb3224e805dfb5489..8edc619666f2980d68b274f5de005c3eb2fe7091 100644

--- a/sky/sdk/lib/framework/widgets/ink_well.dart

+++ b/sky/sdk/lib/framework/widgets/ink_well.dart

@@ -53,7 +53,7 @@ class InkSplash {

well.markNeedsPaint();

}

- void paint(RenderObjectDisplayList canvas) {

+ void paint(sky.Canvas canvas) {

int opacity = (_kSplashInitialOpacity * (1.0 - (_radius.value / _targetRadius))).floor();

sky.Paint paint = new sky.Paint()..color = new sky.Color(opacity << 24);

canvas.drawCircle(position.x, position.y, _radius.value, paint);

@@ -88,7 +88,7 @@ class RenderInkWell extends RenderProxyBox {

markNeedsPaint();

}

- void paint(RenderObjectDisplayList canvas) {

+ void paint(sky.Canvas canvas) {

if (!_splashes.isEmpty) {

canvas.save();

canvas.clipRect(new Rect.fromSize(size));