sky/examples/game/lib/game_demo.dart - Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/examples/game/lib/game_demo.dart

Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co… (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: j/k -- this one should actually be fully merged and testable Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« sky/engine/core/painting/PictureRecorder.cpp ('K') | « sky/engine/core/painting/PictureRecorder.idl ('k') | sky/examples/game/lib/game_demo_world.dart » ('j') | sky/examples/raw/hello_world.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 library game;	1 library game;

2	2

3 import 'dart:sky';	3 import 'dart:sky';

4 import 'dart:math' as Math;	4 import 'dart:math' as Math;

5 import 'package:vector_math/vector_math_64.dart';	5 import 'package:vector_math/vector_math_64.dart';

6 import 'sprites.dart';	6 import 'sprites.dart';

7 import 'package:box2d/box2d.dart';	7 import 'package:box2d/box2d.dart';

	8 import 'package:sky/rendering/object.dart';
	abarth-chromium 2015/06/23 02:28:45 Is this change still needed? Is this change still needed? iansf 2015/06/23 22:46:09 Yes -- otherwise the game doesn't know about Rende Show quoted text On 2015/06/23 02:28:45, abarth wrote: > Is this change still needed? Yes -- otherwise the game doesn't know about RenderCanvas, which is used in the paint calls. Is that problematic?
8	9

9 part 'game_demo_world.dart';	10 part 'game_demo_world.dart';

OLD	NEW