sky/engine/core/painting/PictureRecorder.idl - Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/engine/core/painting/PictureRecorder.idl

Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co… (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Rework the API a bit Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 [	4 [

5 Constructor(double width, double height)	5 Constructor()

6 ] interface PictureRecorder : Canvas {	6 ] interface PictureRecorder {

	7 readonly attribute boolean isRecording;

	8 Canvas beginRecording(double width, double height);

7 Picture endRecording();	9 Picture endRecording();

	10 void setCanvas(Canvas canvas);
	Hixie 2015/06/20 00:44:52 Exposing setCanvas() to dart seems really dodgy to Exposing setCanvas() to dart seems really dodgy to me. What if people call it with random Canvas objects? Or even objects that implement Canvas but aren't actually Canvases? abarth-chromium 2015/06/20 00:50:29 This API doesn't make sense. We should find anoth This API doesn't make sense. We should find another way to solve whatever problem this is solving.
8 };	11 };

OLD	NEW