sky/engine/core/painting/PictureRecorder.idl - Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/engine/core/painting/PictureRecorder.idl

Issue 1190123003: Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia co… (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« sky/engine/core/painting/PictureRecorder.cpp ('K') | « sky/engine/core/painting/PictureRecorder.cpp ('k') | sky/examples/game/lib/sprite_box.dart » ('j') | sky/examples/game/lib/sprite_box.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 [	4 [

5 Constructor(double width, double height)	5 Constructor()

6 ] interface PictureRecorder : Canvas {	6 ] interface PictureRecorder {

	7 Canvas beginRecording(double width, double height);

7 Picture endRecording();	8 Picture endRecording();

	9 boolean isRecording();
	abarth-chromium 2015/06/18 00:03:52 readonly attribute boolean isRecording; That way readonly attribute boolean isRecording; That way it shows up in Dart as an attribute getter instead of a function call. (The C++ side isn't changed.) iansf 2015/06/20 00:02:38 Done. Show quoted text On 2015/06/18 00:03:52, abarth wrote: > readonly attribute boolean isRecording; > > That way it shows up in Dart as an attribute getter instead of a function call. > (The C++ side isn't changed.) Done.
8 };	10 };

OLD	NEW