runtime/vm/flow_graph_compiler.cc - Issue 1190123002: Noopt work: populate empty ICData of getters and setters with function's own class if that getter/s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1190123002: Noopt work: populate empty ICData of getters and setters with function's own class if that getter/s… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: h Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index 3433de04a0cc693ff77918b29c3c2093968b0ca5..485a66ce078c41eaf7021caa4e8e3694d3aa0ad1 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -69,7 +69,8 @@ DECLARE_FLAG(bool, warn_on_javascript_compatibility);

static void NooptModeHandler(bool value) {

if (value) {

- FLAG_always_megamorphic_calls = value;

+ FLAG_always_megamorphic_calls = true;

+ FLAG_polymorphic_with_deopt = false;

FLAG_optimization_counter_threshold = -1;

FLAG_use_field_guards = false;

FLAG_use_osr = false;

« no previous file with comments | « no previous file | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »