LayoutTests/images-temp/size-failure.html - Issue 1190113002: CL to help triage fast/images/size-failure.html crash on XP

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/images-temp/size-failure.html

Issue 1190113002: CL to help triage fast/images/size-failure.html crash on XP (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner)

5 testRunner.dumpAsText();	5 testRunner.dumpAsText();

6 </script>	6 </script>

7	7

8 </head>	8 </head>

9 <body>	9 <body>

10 <!-- This previously tried to read the size of the image when	10 <!-- This previously tried to read the size of the image when

11 ImageDecoder::m_failed was true, triggering either an assert or a	11 ImageDecoder::m_failed was true, triggering either an assert or a

12 read of random memory. Thanks to Robert Swiecki for the test case. -->	12 read of random memory. Thanks to Robert Swiecki for the test case. -->

13 <img src="resources/size-failure.gif">	13 <img src="../fast/images/resources/size-failure.gif">

14 <p>PASS</p>	14 <p>PASS</p>

15 </body>	15 </body>

16 </html>	16 </html>

OLD	NEW