Issue 1190113002: CL to help triage fast/images/size-failure.html crash on XP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1190113002: CL to help triage fast/images/size-failure.html crash on XP (Closed)

Created:
4 years, 10 months ago by Xianzhu

Modified:
4 years, 10 months ago

Reviewers:
Peter Kasting

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

CL to help triage fast/images/size-failure.html crash on XP To see if the test still crashes not running in slimming paint mode. (images-temp/size-failure.html) BUG=501543 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197283

Patch Set 1 #

Total comments: 1

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -0 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+2 lines, -0 lines	1 comment	Download
A	LayoutTests/images-temp/README.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	LayoutTests/images-temp/size-failure.html	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/images-temp/size-failure-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

Committed patchset #1 (id:1) manually as 197283 (presubmit successful).

4 years, 10 months ago (2015-06-17 21:32:13 UTC) #1

Peter Kasting

4 years, 10 months ago (2015-06-17 21:34:42 UTC) #2

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/1190113002/diff/1/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1190113002/diff/1/LayoutTests/TestExpectation...
LayoutTests/TestExpectations:254: crbug.com/501543 [ XP ]
fast/images/size-failure.html [ Crash ]
This change seems unnecessary for now.

Expand Messages | Collapse Messages