build/android/pylib/gtest/test_package.py - Issue 11901003: [Android] Reland 'Keep track of unknown test results at the TestRunner layer.'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package.py

Issue 11901003: [Android] Reland 'Keep track of unknown test results at the TestRunner layer.' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/gtest/single_test_runner.py ('k') | build/android/pylib/utils/flakiness_dashboard_results_uploader.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/gtest/test_package.py

diff --git a/build/android/pylib/gtest/test_package.py b/build/android/pylib/gtest/test_package.py

index cf325c0a1121a6152ff6ad123f711bcc0d0e0a85..d5e14f79d361ee433c736e8bc580923037937a58 100644

--- a/build/android/pylib/gtest/test_package.py

+++ b/build/android/pylib/gtest/test_package.py

@@ -122,8 +122,6 @@ class TestPackage(object):

failed_tests = []

crashed_tests = []

timed_out_tests = []

- overall_fail = False

- overall_timed_out = False

# Test case statuses.

re_run = re.compile('\[ RUN \] ?(.*)\r\n')

@@ -146,7 +144,6 @@ class TestPackage(object):

if found == 1: # re_passed

break

elif found == 2: # re_runner_fail

- overall_fail = True

break

else: # re_run

if self.dump_debug_info:

@@ -159,7 +156,6 @@ class TestPackage(object):

ok_tests += [BaseTestResult(full_test_name, p.before)]

elif found == 2: # re_crash

crashed_tests += [BaseTestResult(full_test_name, p.before)]

- overall_fail = True

break

else: # re_fail

failed_tests += [BaseTestResult(full_test_name, p.before)]

@@ -169,7 +165,6 @@ class TestPackage(object):

except pexpect.TIMEOUT:

logging.error('Test terminated after %d second timeout.',

self.timeout)

- overall_timed_out = True

if full_test_name:

timed_out_tests += [BaseTestResult(full_test_name, p.before)]

finally:

@@ -180,10 +175,7 @@ class TestPackage(object):

logging.critical(

'gtest exit code: %d\npexpect.before: %s\npexpect.after: %s',

ret_code, p.before, p.after)

- overall_fail = True

# Create TestResults and return

return TestResults.FromRun(ok=ok_tests, failed=failed_tests,

- crashed=crashed_tests, timed_out=timed_out_tests,

- overall_fail=overall_fail,

- overall_timed_out=overall_timed_out)

+ crashed=crashed_tests, timed_out=timed_out_tests)