Issue 1190093003: Revert 197289 "Oilpan: Defer reusing freed memory for one GC cycle"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1190093003: Revert 197289 "Oilpan: Defer reusing freed memory for one GC cycle" (Closed)

Created:
4 years, 10 months ago by haraken

Modified:
4 years, 10 months ago

Reviewers:
haraken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 197289 "Oilpan: Defer reusing freed memory for one GC cycle" Broke ASan tests. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/19049 > Oilpan: Defer reusing freed memory for one GC cycle > > This CL defers reusing freed memory for (at least) one GC cycle or coalescing. This is helpful to detect use-after-free errors caused by lazy sweeping (it is scary!). > > Before this CL, the deferment is enabled only on ASan builds. This CL enables the deferment in non-production builds (i.e., ASSERT || LSan || ASan). > > See the comment in addToFreeList() for how the deferment is implemented. > > BUG=420515 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196997 > > Review URL: https://codereview.chromium.org/1176003002 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197316

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -121 lines)			Patch
M	trunk/Source/platform/heap/Heap.h	View	4 chunks	+36 lines, -16 lines	0 comments	Download
M	trunk/Source/platform/heap/Heap.cpp	View	6 chunks	+27 lines, -63 lines	0 comments	Download
M	trunk/Source/platform/heap/HeapTest.cpp	View	2 chunks	+0 lines, -42 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r197316.