Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 1190063002: Test262 update 2015-06-11 (Take 3) (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Test262 update 2015-06-11 (Take 3) This reverts commit 72bb369d08e8d141f77c0c05f95cf8ed7ac5a9ec. Always skip slow tests. Also, some eval tests are failing in strict mode with nosnap BUG=N LOG=N R=adamk@chromium.org, littledan@chromium.org, machenbach@chromium.org Committed: https://crrev.com/0f502f679e339f90bd7e560ffff40c06e471eb40 Cr-Commit-Position: refs/heads/master@{#29164}

Patch Set 1 #

Patch Set 2 : Skip slow tests #

Total comments: 2

Patch Set 3 : Some eval tests are failing with nosnap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -391 lines) Patch
M test/test262-es6/README View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 2 5 chunks +419 lines, -386 lines 0 comments Download
M test/test262-es6/testcfg.py View 2 chunks +13 lines, -2 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
arv (Not doing code reviews)
PTAL Patchset 1 is the revert. Patchset 2 contains the skips of the tests that ...
5 years, 6 months ago (2015-06-18 05:01:00 UTC) #1
Michael Achenbach
LGTM ~ comment. Just realized that our tryserver nosnap trybot doesn't run test262-es6. So ignore ...
5 years, 6 months ago (2015-06-18 08:18:22 UTC) #2
arv (Not doing code reviews)
On 2015/06/18 08:18:22, Michael Achenbach wrote: > LGTM ~ comment. Just realized that our tryserver ...
5 years, 6 months ago (2015-06-18 14:24:35 UTC) #3
arv (Not doing code reviews)
https://codereview.chromium.org/1190063002/diff/20001/test/test262-es6/test262-es6.status File test/test262-es6/test262-es6.status (right): https://codereview.chromium.org/1190063002/diff/20001/test/test262-es6/test262-es6.status#newcode600 test/test262-es6/test262-es6.status:600: On 2015/06/18 08:18:22, Michael Achenbach wrote: > Are you ...
5 years, 6 months ago (2015-06-18 14:24:49 UTC) #4
Michael Achenbach
> Maybe I can add a nosnap bot to the CL description? You can. But ...
5 years, 6 months ago (2015-06-18 16:34:40 UTC) #5
adamk
lgtm
5 years, 6 months ago (2015-06-18 17:08:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190063002/40001
5 years, 6 months ago (2015-06-19 18:10:27 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-19 18:58:09 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 18:58:26 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0f502f679e339f90bd7e560ffff40c06e471eb40
Cr-Commit-Position: refs/heads/master@{#29164}

Powered by Google App Engine
This is Rietveld 408576698