Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: src/objects.h

Issue 1190023002: Use output parameter to distinguish error from absent result (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index e484e3d0563e04bc639b18f816f0c2773dea1f56..2ba840bef4f88f07e2590617ef328225e61b4ff4 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1941,8 +1941,11 @@ class JSObject: public JSReceiver {
Handle<JSObject> object,
Handle<AccessorInfo> info);
+ // The result must be checked first for exceptions. If there's no exception,
+ // the output parameter |done| indicates whether the interceptor has a result
+ // or not.
MUST_USE_RESULT static MaybeHandle<Object> GetPropertyWithInterceptor(
- LookupIterator* it);
+ LookupIterator* it, bool* done);
// Accessors for hidden properties object.
//
« no previous file with comments | « src/ic/ic.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698