Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: src/ic/ic.cc

Issue 1190023002: Use output parameter to distinguish error from absent result (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.cc
diff --git a/src/ic/ic.cc b/src/ic/ic.cc
index d04fc583c44a909cc0d57c900a7da160c88236aa..7c14b5625beb49203ee114964068d6a8cb6e1bad 100644
--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -2771,10 +2771,11 @@ RUNTIME_FUNCTION(LoadPropertyWithInterceptorOnly) {
args.at<JSObject>(NamedLoadHandlerCompiler::kInterceptorArgsHolderIndex);
HandleScope scope(isolate);
LookupIterator it(receiver, name, holder, LookupIterator::OWN);
- auto res = JSObject::GetPropertyWithInterceptor(&it);
- RETURN_FAILURE_IF_SCHEDULED_EXCEPTION(isolate);
+ bool done;
Handle<Object> result;
- if (res.ToHandle(&result)) return *result;
+ ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
+ isolate, result, JSObject::GetPropertyWithInterceptor(&it, &done));
+ if (done) return *result;
return isolate->heap()->no_interceptor_result_sentinel();
}
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698