Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1190023002: Use output parameter to distinguish error from absent result (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use output parameter to distinguish error from absent result Otherwise we'd have to probe for pending exceptions. I'll do the same to other interceptors in follow-up CLs BUG=chromium:495949, v8:4137 LOG=n Committed: https://crrev.com/9a92d294f394ee3f19ccb647d148d691e5498010 Cr-Commit-Position: refs/heads/master@{#29090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M src/ic/ic.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/objects.cc View 6 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-17 13:23:41 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-17 13:35:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190023002/1
5 years, 6 months ago (2015-06-17 13:38:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 14:06:36 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 14:06:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a92d294f394ee3f19ccb647d148d691e5498010
Cr-Commit-Position: refs/heads/master@{#29090}

Powered by Google App Engine
This is Rietveld 408576698