Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 11900002: Revert 176882 - Test fails on Win Aura. (Closed)

Created:
7 years, 11 months ago by Patrick Dubroy
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert 176882 - Test fails on Win Aura. > Test that 404 subresource bodies with nested message loops don't crash. > > This is a browser test because DumpRenderTree doesn't run nested message loops. The failure case was that a nested message triggered from an element that has signalled an error but had an open request would receive a body for the request and crash/fail an assertion. > > This test checks the WebKit side fix for this issue, see https://bugs.webkit.org/show_bug.cgi?id=103563 > > R=sky@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/11778083 TBR=gavinp@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
content/browser/webkit_browsertest.cc View 1 chunk +0 lines, -15 lines 0 comments Download
content/test/data/error-body-no-crash.html View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Patrick Dubroy
7 years, 11 months ago (2013-01-15 13:57:01 UTC) #1
Patrick Dubroy
This test is failing on Win Aura: http://build.chromium.org/p/chromium.win/builders/Win%20Aura%20Tests%20%281%29/builds/669/steps/content_browsertests/logs/stdio [==========] Running 1 test from 1 test ...
7 years, 11 months ago (2013-01-15 13:58:10 UTC) #2
gavinp
7 years, 11 months ago (2013-01-17 14:42:37 UTC) #3
LGTM.

Boy this is going to be fun to figure out.

Japhat, how much does this scare you? The WebKit rev seems to include my fix
(some aura tries earlier were using WebKit older than LKGR...), but still the
crash. I'll spin up a win aura build ASAP to test this, but it could be a week
or two unless we panic.

Powered by Google App Engine
This is Rietveld 408576698