Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 1189983002: bindings: Fixes a flaky test cross-origin-objects.html. (Closed)

Created:
4 years, 10 months ago by Yuki
Modified:
4 years, 10 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Fixes a flaky test cross-origin-objects.html. Fixes flakiness of cross-origin-objects.html. My understanding is that the navigation is done asynchronously, and until the navigation actually happens, the test is running in an unexpected domain. It caused flakiness. Fixed the test so that it does nothing in an unexpected domain. BUG=501284 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197299

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M LayoutTests/http/tests/security/w3c/cross-origin-objects.html View 3 chunks +10 lines, -7 lines 3 comments Download

Messages

Total messages: 9 (2 generated)
Yuki
Could you guys review this CL?
4 years, 10 months ago (2015-06-17 07:28:19 UTC) #2
tkent
https://codereview.chromium.org/1189983002/diff/1/LayoutTests/http/tests/security/w3c/cross-origin-objects.html File LayoutTests/http/tests/security/w3c/cross-origin-objects.html (right): https://codereview.chromium.org/1189983002/diff/1/LayoutTests/http/tests/security/w3c/cross-origin-objects.html#newcode23 LayoutTests/http/tests/security/w3c/cross-origin-objects.html:23: document.location = document.location.protocol + "//web-platform.test:8000" + document.location.pathname; Do we ...
4 years, 10 months ago (2015-06-17 07:41:16 UTC) #3
Yuki
https://codereview.chromium.org/1189983002/diff/1/LayoutTests/http/tests/security/w3c/cross-origin-objects.html File LayoutTests/http/tests/security/w3c/cross-origin-objects.html (right): https://codereview.chromium.org/1189983002/diff/1/LayoutTests/http/tests/security/w3c/cross-origin-objects.html#newcode23 LayoutTests/http/tests/security/w3c/cross-origin-objects.html:23: document.location = document.location.protocol + "//web-platform.test:8000" + document.location.pathname; On 2015/06/17 ...
4 years, 10 months ago (2015-06-17 08:25:17 UTC) #4
tkent
https://codereview.chromium.org/1189983002/diff/1/LayoutTests/http/tests/security/w3c/cross-origin-objects.html File LayoutTests/http/tests/security/w3c/cross-origin-objects.html (right): https://codereview.chromium.org/1189983002/diff/1/LayoutTests/http/tests/security/w3c/cross-origin-objects.html#newcode23 LayoutTests/http/tests/security/w3c/cross-origin-objects.html:23: document.location = document.location.protocol + "//web-platform.test:8000" + document.location.pathname; On 2015/06/17 ...
4 years, 10 months ago (2015-06-18 00:41:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189983002/1
4 years, 10 months ago (2015-06-18 00:42:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197299
4 years, 10 months ago (2015-06-18 00:48:14 UTC) #8
haraken
4 years, 10 months ago (2015-06-18 01:00:41 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698