Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 1189963003: Templatize PendingSelection class (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent, hajimehoshi
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize PendingSelection class Now |PendingSelection| works only on DOM tree. This patch templatizes |PendingSelection| class and end enables it to allow other node-traversing strategies, such as composed tree. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197256

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M Source/core/editing/VisibleSelection.h View 1 chunk +10 lines, -0 lines 1 comment Download
M Source/core/layout/PendingSelection.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/layout/PendingSelection.cpp View 2 chunks +25 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-17 08:02:09 UTC) #2
tkent
lgtm https://codereview.chromium.org/1189963003/diff/1/Source/core/editing/VisibleSelection.h File Source/core/editing/VisibleSelection.h (right): https://codereview.chromium.org/1189963003/diff/1/Source/core/editing/VisibleSelection.h#newcode46 Source/core/editing/VisibleSelection.h:46: class InDOMTree { The name |InDOMTree| sounds weird ...
4 years, 10 months ago (2015-06-17 08:14:29 UTC) #3
yosin_UTC9
On 2015/06/17 08:14:29, tkent wrote: > lgtm > > https://codereview.chromium.org/1189963003/diff/1/Source/core/editing/VisibleSelection.h > File Source/core/editing/VisibleSelection.h (right): > ...
4 years, 10 months ago (2015-06-17 08:58:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189963003/1
4 years, 10 months ago (2015-06-17 08:58:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66984)
4 years, 10 months ago (2015-06-17 11:05:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189963003/1
4 years, 10 months ago (2015-06-17 11:14:10 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 12:16:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197256

Powered by Google App Engine
This is Rietveld 408576698