Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1189943004: Fork some more files from the old framework, so that the transition will be easier to perform. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fork some more files from the old framework, so that the transition will be easier to perform. Summary: framework/animation/* -> animation/* framework/debug/utils.dart -> debug/utils.dart framework/shell.dart -> mojo/shell.dart framework/embedder.dart -> mojo/embedder.dart framework/net/* -> mojo/net/* This should have no code changes except fixing and reordering imports. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6f98d82918efbb05bd80ae1966ed66e79e14dcf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -33 lines) Patch
M sky/sdk/BUILD.gn View 3 chunks +11 lines, -1 line 0 comments Download
A sky/sdk/lib/animation/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A + sky/sdk/lib/animation/animated_value.dart View 1 chunk +2 lines, -1 line 0 comments Download
A + sky/sdk/lib/animation/curves.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/animation/fling_curve.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/animation/generators.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A + sky/sdk/lib/animation/mechanics.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/animation/scroll_behavior.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + sky/sdk/lib/debug/utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/sdk/lib/framework/debug/utils.dart View 1 chunk +0 lines, -12 lines 0 comments Download
A + sky/sdk/lib/mojo/embedder.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + sky/sdk/lib/mojo/net/fetch.dart View 1 chunk +3 lines, -1 line 0 comments Download
A + sky/sdk/lib/mojo/net/image_cache.dart View 1 chunk +3 lines, -1 line 0 comments Download
A + sky/sdk/lib/mojo/shell.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/rendering/box.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/animated_component.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/fixed_height_scrollable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/ink_well.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/toggleable.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-18 01:44:10 UTC) #2
Hixie
5 years, 6 months ago (2015-06-18 02:09:33 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6f98d82918efbb05bd80ae1966ed66e79e14dcf2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698