Suppress VersionInfoUpdater::OnBootTimes() from ASAN until the bug is fixed.

chrome/browser/chromeos/login/version_info_updater.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/version_info_updater.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 138 matching lines @@
 }
 
 void VersionInfoUpdater::OnVersion(const std::string& version) {
   version_text_ = version;
   UpdateVersionLabel();
 }
 
 void VersionInfoUpdater::OnBootTimesNoop(
     const BootTimesLoader::BootTimes& boot_times) {}
 
+// ASAN finds bug in the following function: crbug.com/170034.

[Nikita (slow), 2013/01/15 14:02:50]

Comment should be simplified:

// Mask it out for ASAN before the bug is fixed, see crbug.com/170034

+// Mask it out for ASAN before the bug is fixed.
+#if defined(ADDRESS_SANITIZER)
+__attribute__((no_address_safety_analysis))

[Nikita (slow), 2013/01/15 14:02:50]

Could we use a similar mechanism that is used to supress ASAN errors on other
platforms instead?

+#endif  // defined(ADDRESS_SANITIZER)
 void VersionInfoUpdater::OnBootTimes(
     const BootTimesLoader::BootTimes& boot_times) {
   const char* kBootTimesNoChromeExec =
       "Non-firmware boot took %.2f seconds (kernel %.2fs, system %.2fs)";
   const char* kBootTimesChromeExec =
       "Non-firmware boot took %.2f seconds "
       "(kernel %.2fs, system %.2fs, chrome %.2fs)";
   std::string boot_times_text;
 
   if (boot_times.chrome > 0) {
@@ skipping 35 matching lines @@
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   if (type == chrome::NOTIFICATION_SYSTEM_SETTING_CHANGED)
     UpdateEnterpriseInfo();
   else
     NOTREACHED();
 }
 
 }  // namespace chromeos