Issue 1189893002: Add a basic Dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1189893002: Add a basic Dialog (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
jackson, jackson_old, Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add a basic Dialog The dialog will need many more features to be complete, but this class is a basic skeleton of what we'll need. R=jackson@google.com, jackson@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/69968778dca8cac8cd193c5be1547b4e70fb3de0

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -0 lines)			Patch
M	sky/sdk/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/sdk/lib/widgets/dialog.dart	View	1 chunk	+53 lines, -0 lines	0 comments	Download
A	sky/tests/widgets/dialog.dart	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	sky/tests/widgets/dialog-expected.txt	View	1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

abarth-chromium

Committed patchset #1 (id:1) manually as 69968778dca8cac8cd193c5be1547b4e70fb3de0 (presubmit successful).

5 years, 6 months ago (2015-06-17 00:11:30 UTC) #4

Message was sent while issue was closed.

lgtm