Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1189863003: Revert of Update V8 to version 4.5.56. (Closed)

Created:
5 years, 6 months ago by Zhenyao Mo
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 4.5.56. (patchset #1 id:1 of https://codereview.chromium.org/1182893005/) Reason for revert: Broke WebGL 2 conformance tests Fatal error in ../../v8/src/ic/stub-cache.h, line 111 # Check failed: name->HasHashCode(). build chrome, run with --enable-unsafe-es3-apis goto https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html select Version 2.0.0 (beta) in the dropbox, and run samplerobejct.html (may need to run twice) Original issue's description: > Update V8 to version 4.5.56. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/fffc68e8..cb392cb0 > > Please follow these instructions for assigning/CC'ing issues: > https://code.google.com/p/v8-wiki/wiki/TriagingIssues > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/a08e761a4a4f5c863682a39e234b4ca3af170159 > Cr-Commit-Position: refs/heads/master@{#334571} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c892234df05c86f1c19d0f515c4b0fc2be5e287b Cr-Commit-Position: refs/heads/master@{#334649}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (2 generated)
Zhenyao Mo
Created Revert of Update V8 to version 4.5.56.
5 years, 6 months ago (2015-06-16 16:57:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189863003/1
5 years, 6 months ago (2015-06-16 16:59:09 UTC) #2
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
5 years, 6 months ago (2015-06-16 17:00:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189863003/40001
5 years, 6 months ago (2015-06-16 18:47:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-16 18:50:10 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c892234df05c86f1c19d0f515c4b0fc2be5e287b Cr-Commit-Position: refs/heads/master@{#334649}
5 years, 6 months ago (2015-06-16 18:51:43 UTC) #8
Michael Hablich
On 2015/06/16 18:51:43, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
5 years, 6 months ago (2015-06-16 18:54:10 UTC) #9
chromium-reviews
FYI: One of the bots where this failed: http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds/36454 On Tue, Jun 16, 2015 at ...
5 years, 6 months ago (2015-06-16 20:24:23 UTC) #10
Zhenyao Mo
On 2015/06/16 20:24:23, chromium-reviews wrote: > FYI: One of the bots where this failed: > ...
5 years, 6 months ago (2015-06-16 20:26:04 UTC) #11
chromium-reviews
According to zmo, there's no trybot support yet. The tryjobs that I've sent also doesn't ...
5 years, 6 months ago (2015-06-16 21:15:49 UTC) #12
chromium-reviews
FYI: Also on the linux trybot that landed the v8 roll, this test failed once: ...
5 years, 6 months ago (2015-06-16 21:18:54 UTC) #13
chromium-reviews
5 years, 6 months ago (2015-06-16 21:20:28 UTC) #14
Message was sent while issue was closed.
FYI: Some repro attempts: https://codereview.chromium.org/1188903002/

Logging off from here...

On Tue, Jun 16, 2015 at 11:18 PM, Michael Achenbach <machenbach@google.com>
wrote:

> FYI: Also on the linux trybot that landed the v8 roll, this test failed
> once:
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
>
> So, repro'ing on the trybot should be possible, though flaky.
>
> On Tue, Jun 16, 2015 at 11:15 PM, Michael Achenbach <machenbach@google.com
> > wrote:
>
>> According to zmo, there's no trybot support yet. The tryjobs that I've
>> sent also doesn't repro with Yang's CL. But it looks to me as if those test
>> are run:
>>
>>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...
>>
>> The test that failed here
>>
http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds...
>> ran on that trybot. Or is this some different configuration?
>>
>> I assume the trybot uses dchecks_always_on - but maybe we need a real
>> debug build.
>>
>> On Tue, Jun 16, 2015 at 10:26 PM, <zmo@chromium.org> wrote:
>>
>>> On 2015/06/16 20:24:23, chromium-reviews wrote:
>>>
>>>> FYI: One of the bots where this failed:
>>>>
>>>
>>>
>>>
http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds...
>>>
>>> Thanks.  I also reproduced locally on my Linux machine with the
>>> instructions in
>>> the CL description.  It's very easy to induce the assertion failure.
>>>
>>> https://codereview.chromium.org/1189863003/
>>>
>>
>>
>>
>> --
>> Michael Achenbach
>> V8 Test Engineer
>> Google Germany GmbH
>> Dienerstr. 12
>> 80331 München
>> *----------------------------------------------
>> Registergericht und -nummer: Hamburg, HRB 86891
>> Sitz der Gesellschaft: Hamburg
>> Geschäftsführer: Graham Law, Katherine Stephens
>> ----------------------------------------------
>>
>
>
>
> --
> Michael Achenbach
> V8 Test Engineer
> Google Germany GmbH
> Dienerstr. 12
> 80331 München
> *----------------------------------------------
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschäftsführer: Graham Law, Katherine Stephens
> ----------------------------------------------
>



-- 
Michael Achenbach
V8 Test Engineer
Google Germany GmbH
Dienerstr. 12
80331 München
*----------------------------------------------
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens
----------------------------------------------

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698