Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years, 6 months ago by Zhenyao Mo Modified:
5 years, 6 months ago Reviewers:
vogelheim, Michael Hablich, v8-autoroll, Yang, Michael Achenbach CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Update V8 to version 4.5.56. (patchset #1 id:1 of https://codereview.chromium.org/1182893005/)
Reason for revert:
Broke WebGL 2 conformance tests
Fatal error in ../../v8/src/ic/stub-cache.h, line 111
# Check failed: name->HasHashCode().
build chrome, run with --enable-unsafe-es3-apis
goto https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html
select Version 2.0.0 (beta) in the dropbox, and run samplerobejct.html (may need to run twice)
Original issue's description:
> Update V8 to version 4.5.56.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/fffc68e8..cb392cb0
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
>
> Committed: https://crrev.com/a08e761a4a4f5c863682a39e234b4ca3af170159
> Cr-Commit-Position: refs/heads/master@{#334571}
TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/c892234df05c86f1c19d0f515c4b0fc2be5e287b
Cr-Commit-Position: refs/heads/master@{#334649}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 14 (2 generated)
Created Revert of Update V8 to version 4.5.56.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189863003/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch failed: DEPS:38 error: repository lacks the necessary blob to fall back on 3-way merge. error: DEPS: patch does not apply Patch: DEPS Index: DEPS diff --git a/DEPS b/DEPS index 361af7e03f72ef10c02ad93306867534574e4c54..00dd51ec0c7a7c4c06728dbd8e89e9f7bd1c321f 100644 --- a/DEPS +++ b/DEPS @@ -38,7 +38,7 @@ # Three lines of non-changing comments so that # the commit queue can handle CLs rolling V8 # and whatever else without interference from each other. - 'v8_revision': 'cb392cb03a1d4ac89b6c1b8a67af9ea2740613f8', + 'v8_revision': 'fffc68e8cae31678d198db13d72f92632b825bf5', # Three lines of non-changing comments so that # the commit queue can handle CLs rolling swarming_client # and whatever else without interference from each other.
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189863003/40001
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c892234df05c86f1c19d0f515c4b0fc2be5e287b Cr-Commit-Position: refs/heads/master@{#334649}
Message was sent while issue was closed.
On 2015/06/16 18:51:43, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/c892234df05c86f1c19d0f515c4b0fc2be5e287b > Cr-Commit-Position: refs/heads/master@{#334649} I closed the auto-roller until this is resolved.
Message was sent while issue was closed.
FYI: One of the bots where this failed: http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds... On Tue, Jun 16, 2015 at 8:54 PM, <hablich@chromium.org> wrote: > On 2015/06/16 18:51:43, commit-bot: I haz the power wrote: > >> Patchset 2 (id:??) landed as >> https://crrev.com/c892234df05c86f1c19d0f515c4b0fc2be5e287b >> Cr-Commit-Position: refs/heads/master@{#334649} >> > > I closed the auto-roller until this is resolved. > > https://codereview.chromium.org/1189863003/ > -- Michael Achenbach V8 Test Engineer Google Germany GmbH Dienerstr. 12 80331 München *---------------------------------------------- Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens ---------------------------------------------- To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
On 2015/06/16 20:24:23, chromium-reviews wrote: > FYI: One of the bots where this failed: > http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds... Thanks. I also reproduced locally on my Linux machine with the instructions in the CL description. It's very easy to induce the assertion failure.
Message was sent while issue was closed.
According to zmo, there's no trybot support yet. The tryjobs that I've sent also doesn't repro with Yang's CL. But it looks to me as if those test are run: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_... The test that failed here http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds... ran on that trybot. Or is this some different configuration? I assume the trybot uses dchecks_always_on - but maybe we need a real debug build. On Tue, Jun 16, 2015 at 10:26 PM, <zmo@chromium.org> wrote: > On 2015/06/16 20:24:23, chromium-reviews wrote: > >> FYI: One of the bots where this failed: >> > > > http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds... > > Thanks. I also reproduced locally on my Linux machine with the > instructions in > the CL description. It's very easy to induce the assertion failure. > > https://codereview.chromium.org/1189863003/ > -- Michael Achenbach V8 Test Engineer Google Germany GmbH Dienerstr. 12 80331 München *---------------------------------------------- Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens ---------------------------------------------- To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
FYI: Also on the linux trybot that landed the v8 roll, this test failed once: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_... So, repro'ing on the trybot should be possible, though flaky. On Tue, Jun 16, 2015 at 11:15 PM, Michael Achenbach <machenbach@google.com> wrote: > According to zmo, there's no trybot support yet. The tryjobs that I've > sent also doesn't repro with Yang's CL. But it looks to me as if those test > are run: > > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_... > > The test that failed here > http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds... > ran on that trybot. Or is this some different configuration? > > I assume the trybot uses dchecks_always_on - but maybe we need a real > debug build. > > On Tue, Jun 16, 2015 at 10:26 PM, <zmo@chromium.org> wrote: > >> On 2015/06/16 20:24:23, chromium-reviews wrote: >> >>> FYI: One of the bots where this failed: >>> >> >> >> http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds... >> >> Thanks. I also reproduced locally on my Linux machine with the >> instructions in >> the CL description. It's very easy to induce the assertion failure. >> >> https://codereview.chromium.org/1189863003/ >> > > > > -- > Michael Achenbach > V8 Test Engineer > Google Germany GmbH > Dienerstr. 12 > 80331 München > *---------------------------------------------- > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Katherine Stephens > ---------------------------------------------- > -- Michael Achenbach V8 Test Engineer Google Germany GmbH Dienerstr. 12 80331 München *---------------------------------------------- Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens ---------------------------------------------- To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
FYI: Some repro attempts: https://codereview.chromium.org/1188903002/ Logging off from here... On Tue, Jun 16, 2015 at 11:18 PM, Michael Achenbach <machenbach@google.com> wrote: > FYI: Also on the linux trybot that landed the v8 roll, this test failed > once: > > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_... > > So, repro'ing on the trybot should be possible, though flaky. > > On Tue, Jun 16, 2015 at 11:15 PM, Michael Achenbach <machenbach@google.com > > wrote: > >> According to zmo, there's no trybot support yet. The tryjobs that I've >> sent also doesn't repro with Yang's CL. But it looks to me as if those test >> are run: >> >> http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_... >> >> The test that failed here >> http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds... >> ran on that trybot. Or is this some different configuration? >> >> I assume the trybot uses dchecks_always_on - but maybe we need a real >> debug build. >> >> On Tue, Jun 16, 2015 at 10:26 PM, <zmo@chromium.org> wrote: >> >>> On 2015/06/16 20:24:23, chromium-reviews wrote: >>> >>>> FYI: One of the bots where this failed: >>>> >>> >>> >>> http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds... >>> >>> Thanks. I also reproduced locally on my Linux machine with the >>> instructions in >>> the CL description. It's very easy to induce the assertion failure. >>> >>> https://codereview.chromium.org/1189863003/ >>> >> >> >> >> -- >> Michael Achenbach >> V8 Test Engineer >> Google Germany GmbH >> Dienerstr. 12 >> 80331 München >> *---------------------------------------------- >> Registergericht und -nummer: Hamburg, HRB 86891 >> Sitz der Gesellschaft: Hamburg >> Geschäftsführer: Graham Law, Katherine Stephens >> ---------------------------------------------- >> > > > > -- > Michael Achenbach > V8 Test Engineer > Google Germany GmbH > Dienerstr. 12 > 80331 München > *---------------------------------------------- > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Katherine Stephens > ---------------------------------------------- > -- Michael Achenbach V8 Test Engineer Google Germany GmbH Dienerstr. 12 80331 München *---------------------------------------------- Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens ---------------------------------------------- To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
