Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 1189863002: nanobench: split CPU and GPU .SKP tile sizes. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org, herb_g, borenet
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

nanobench: split CPU and GPU .SKP tile sizes. Let's make CPU-bound .SKP benching mimic Chrome's tiles. Unfortunately, the CPU code also performs a lot better with those big wide tiles... BUG=skia: Committed: https://skia.googlesource.com/skia/+/bf9e60006987f23773b1e0bdfad9d424d4bc5170

Patch Set 1 #

Patch Set 2 : winders #

Patch Set 3 : update flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M bench/SKPBench.cpp View 1 2 chunks +12 lines, -4 lines 0 comments Download
M tools/nanobench_flags.json View 1 2 1 chunk +24 lines, -2 lines 0 comments Download
M tools/nanobench_flags.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
mtklein_C
5 years, 6 months ago (2015-06-16 16:54:39 UTC) #2
mtklein_C
+CC herb, I think this is why we're not seeing glyph cache contention to be ...
5 years, 6 months ago (2015-06-16 16:56:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189863002/1
5 years, 6 months ago (2015-06-16 16:56:51 UTC) #5
mtklein
(I say more like because the real logic is somewhat more interesting: https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/gpu/render_widget_compositor.cc&rcl=1434454215&l=130 )
5 years, 6 months ago (2015-06-16 16:58:27 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1531) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 6 months ago (2015-06-16 17:00:31 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189863002/20001
5 years, 6 months ago (2015-06-16 17:03:30 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 17:08:41 UTC) #13
robertphillips
lgtm. Do we use the old command line args anywhere?
5 years, 6 months ago (2015-06-16 17:26:17 UTC) #14
mtklein
Ooh, good catch. Yes, we did set back to 256x256 on HD2000. Updated.
5 years, 6 months ago (2015-06-16 17:35:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189863002/40001
5 years, 6 months ago (2015-06-16 17:36:22 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/bf9e60006987f23773b1e0bdfad9d424d4bc5170
5 years, 6 months ago (2015-06-16 17:41:32 UTC) #19
mtklein
5 years, 6 months ago (2015-06-16 20:32:10 UTC) #20
Message was sent while issue was closed.
+Eric

Hey Sheriff, 

FYI, this CL is expected to totally wreck perf.skia.org.  It'll affect all the
SKPs on all the CPU bots.  Some bots will go faster, some bots will go slower. 
Some SKPs will go faster, some SKPs will go slower.

Interestingly, the arithmetic mean runtime has gone up, but the geometric mean
runtime has gone down: https://perf.skia.org/#3633.  I think that means it's
generally faster but has introduced a few severe performance regressions.

If perf alerts come up I'll try to triage them, but it should be fine to just
tag them all ignored "mtklein says so" if I miss any.

Powered by Google App Engine
This is Rietveld 408576698