|
Revert of Support impl-side painting in Mandoline. (patchset #19 id:370001 of https://codereview.chromium.org/1181013010/)
Reason for revert:
The same compile errors also happen on the Win x64 GN bot:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/2869/steps/compile/logs/stdio
e:\b\build\slave\win_x64_gn\build\src\mojo\gles2\command_buffer_client_impl.cc(255) :error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn\build\src\mojo\gles2\command_buffer_client_impl.cc(255) : warning C4267: '=' : conversion from 'size_t' to 'int32_t', possible loss of data
e:\b\build\slave\win_x64_gn\build\src\mojo\gles2\command_buffer_client_impl.cc(256) : warning C4267: '=' : conversion from 'size_t' to 'int32_t', possible loss of data
e:\b\build\slave\win_x64_gn\build\src\mojo\gles2\command_buffer_client_impl.cc(313) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
Original issue's description:
> Support impl-side painting in Mandoline.
>
> This is now the default in cc and the old code paths are being removed, so we need to use impl-side painting. The changes are:
> -add necessary thunks for the gl methods
> -expose gpu::GpuMemoryBufferManager and cc::TaskGraphRunner in ui and html_viewer
> -IPC to view_manager and call the GPU code (modelled on content)
>
> BUG= 499030
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/b14138431960bb3542e7b1b7447363ef13528e0d
> Cr-Commit-Position: refs/heads/master@{#334602}
TBR=sky@chromium.org,piman@chromium.org,danakj@chromium.org,yzshen@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 499030
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+3979 lines, -4995 lines) |
Patch |
 |
M |
components/html_viewer/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/html_viewer/discardable_memory_allocator.h
|
View
|
|
4 chunks |
+12 lines, -20 lines |
0 comments
|
Download
|
 |
M |
components/html_viewer/discardable_memory_allocator.cc
|
View
|
|
4 chunks |
+75 lines, -52 lines |
0 comments
|
Download
|
 |
M |
components/html_viewer/discardable_memory_allocator_unittest.cc
|
View
|
|
1 chunk |
+15 lines, -8 lines |
0 comments
|
Download
|
 |
M |
components/html_viewer/html_document.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/html_viewer/setup.h
|
View
|
|
3 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
components/html_viewer/web_layer_tree_view_impl.h
|
View
|
|
2 chunks |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
M |
components/html_viewer/web_layer_tree_view_impl.cc
|
View
|
|
2 chunks |
+2 lines, -8 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/BUILD.gn
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/gles2/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/gles2/DEPS
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/gles2/command_buffer_driver.h
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/gles2/command_buffer_driver.cc
|
View
|
|
2 chunks |
+0 lines, -83 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/gles2/command_buffer_impl.h
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/gles2/command_buffer_impl.cc
|
View
|
|
1 chunk |
+0 lines, -19 lines |
0 comments
|
Download
|
 |
D |
components/view_manager/gles2/mojo_gpu_memory_buffer.h
|
View
|
|
1 chunk |
+0 lines, -48 lines |
0 comments
|
Download
|
 |
D |
components/view_manager/gles2/mojo_gpu_memory_buffer.cc
|
View
|
|
1 chunk |
+0 lines, -180 lines |
0 comments
|
Download
|
 |
D |
components/view_manager/gles2/mojo_gpu_memory_buffer_manager.h
|
View
|
|
1 chunk |
+0 lines, -33 lines |
0 comments
|
Download
|
 |
D |
components/view_manager/gles2/mojo_gpu_memory_buffer_manager.cc
|
View
|
|
1 chunk |
+0 lines, -37 lines |
0 comments
|
Download
|
 |
D |
components/view_manager/gles2/raster_thread_helper.h
|
View
|
|
1 chunk |
+0 lines, -34 lines |
0 comments
|
Download
|
 |
D |
components/view_manager/gles2/raster_thread_helper.cc
|
View
|
|
1 chunk |
+0 lines, -39 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/public/interfaces/command_buffer.mojom
|
View
|
|
2 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/surfaces/surfaces_context_provider.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/build_gles2_cmd_buffer.py
|
View
|
|
10 chunks |
+10 lines, -24 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h
|
View
|
|
2 chunks |
+3836 lines, -3836 lines |
0 comments
|
Download
|
 |
M |
mandoline/ui/aura/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
mandoline/ui/aura/surface_context_factory.h
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
mandoline/ui/aura/surface_context_factory.cc
|
View
|
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
mojo/cc/context_provider_mojo.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
mojo/gles2/command_buffer_client_impl.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
mojo/gles2/command_buffer_client_impl.cc
|
View
|
|
4 chunks |
+8 lines, -62 lines |
0 comments
|
Download
|
 |
M |
mojo/gles2/gles2_impl.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
mojo/gpu/mojo_gles2_impl_autogen.cc
|
View
|
|
6 chunks |
+13 lines, -23 lines |
0 comments
|
Download
|
 |
M |
mojo/runner/native_application_support.cc
|
View
|
|
2 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
third_party/mojo/src/mojo/public/c/gles2/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/c/gles2/chromium_copy_texture.h
|
View
|
|
1 chunk |
+0 lines, -30 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/c/gles2/chromium_image.h
|
View
|
|
1 chunk |
+0 lines, -32 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/c/gles2/chromium_pixel_transfer_buffer_object.h
|
View
|
|
1 chunk |
+0 lines, -30 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/c/gles2/gles2_call_visitor_chromium_copy_texture_autogen.h
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/c/gles2/gles2_call_visitor_chromium_image_autogen.h
|
View
|
|
1 chunk |
+0 lines, -29 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/c/gles2/gles2_call_visitor_chromium_pixel_transfer_buffer_object_autogen.h
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
 |
M |
third_party/mojo/src/mojo/public/platform/native/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/platform/native/gles2_impl_chromium_copy_texture_thunks.h
|
View
|
|
1 chunk |
+0 lines, -44 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/platform/native/gles2_impl_chromium_copy_texture_thunks.cc
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/platform/native/gles2_impl_chromium_image_thunks.h
|
View
|
|
1 chunk |
+0 lines, -44 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/platform/native/gles2_impl_chromium_image_thunks.cc
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/platform/native/gles2_impl_chromium_pixel_transfer_buffer_object_thunks.h
|
View
|
|
1 chunk |
+0 lines, -44 lines |
0 comments
|
Download
|
 |
D |
third_party/mojo/src/mojo/public/platform/native/gles2_impl_chromium_pixel_transfer_buffer_object_thunks.cc
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|