Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: Source/modules/webaudio/MediaElementAudioSourceNode.cpp

Issue 1189833003: Validate execution context before printing CORS message (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/MediaElementAudioSourceNode.cpp
diff --git a/Source/modules/webaudio/MediaElementAudioSourceNode.cpp b/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
index 91d945b1f63c1a1f81ccbe8719fdc164eb4349ff..3974efb758ae1f6e5bea9f66bbf568b4bd75bfc1 100644
--- a/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
+++ b/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
@@ -141,9 +141,11 @@ bool MediaElementAudioSourceHandler::passesCurrentSrcCORSAccessCheck(const KURL&
void MediaElementAudioSourceHandler::printCORSMessage(const String& message)
{
- context()->executionContext()->addConsoleMessage(
- ConsoleMessage::create(SecurityMessageSource, InfoMessageLevel,
- "MediaElementAudioSource outputs zeroes due to CORS access restrictions for " + message));
+ if (context()->executionContext()) {
hongchan 2015/06/16 16:12:10 What happens if executionContext() does not exist?
+ context()->executionContext()->addConsoleMessage(
+ ConsoleMessage::create(SecurityMessageSource, InfoMessageLevel,
+ "MediaElementAudioSource outputs zeroes due to CORS access restrictions for " + message));
+ }
}
void MediaElementAudioSourceHandler::process(size_t numberOfFrames)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698