Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 1189833003: Validate execution context before printing CORS message (Closed)

Created:
4 years, 10 months ago by Raymond Toy
Modified:
4 years, 10 months ago
Reviewers:
hongchan
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Validate execution context before printing CORS message Need to check that context()->executionContext() is valid before we try to print the CORS restriction message. BUG=500929 TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197203

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 chunk +5 lines, -3 lines 1 comment Download

Messages

Total messages: 12 (4 generated)
Raymond Toy
PTAL.
4 years, 10 months ago (2015-06-16 16:07:19 UTC) #2
hongchan
https://codereview.chromium.org/1189833003/diff/1/Source/modules/webaudio/MediaElementAudioSourceNode.cpp File Source/modules/webaudio/MediaElementAudioSourceNode.cpp (right): https://codereview.chromium.org/1189833003/diff/1/Source/modules/webaudio/MediaElementAudioSourceNode.cpp#newcode144 Source/modules/webaudio/MediaElementAudioSourceNode.cpp:144: if (context()->executionContext()) { What happens if executionContext() does not ...
4 years, 10 months ago (2015-06-16 16:12:10 UTC) #3
Raymond Toy
On 2015/06/16 16:12:10, hoch wrote: > https://codereview.chromium.org/1189833003/diff/1/Source/modules/webaudio/MediaElementAudioSourceNode.cpp > File Source/modules/webaudio/MediaElementAudioSourceNode.cpp (right): > > https://codereview.chromium.org/1189833003/diff/1/Source/modules/webaudio/MediaElementAudioSourceNode.cpp#newcode144 > ...
4 years, 10 months ago (2015-06-16 16:17:35 UTC) #4
hongchan
lgtm
4 years, 10 months ago (2015-06-16 16:25:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189833003/1
4 years, 10 months ago (2015-06-16 16:28:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66828)
4 years, 10 months ago (2015-06-16 18:24:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189833003/1
4 years, 10 months ago (2015-06-16 20:49:18 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 21:47:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197203

Powered by Google App Engine
This is Rietveld 408576698