Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1189823003: Disable BootstrapSandbox on Mac. (Closed)

Created:
5 years, 6 months ago by Will Harris
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable BootstrapSandbox on Mac. Disable BootstrapSandbox on Mac, because of an issue where the constructor is called on the wrong thread. BUG=501128 Committed: https://crrev.com/f1118ad1db53d8ec6be1f24afec3b03d96c01037 Cr-Commit-Position: refs/heads/master@{#334823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/bootstrap_sandbox_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Will Harris
rsesek - once I get an l-g-t-m from you I'll hopefully find an owner... :)
5 years, 6 months ago (2015-06-16 23:00:51 UTC) #2
Robert Sesek
LGTM
5 years, 6 months ago (2015-06-16 23:01:33 UTC) #3
Will Harris
nick - PTAL
5 years, 6 months ago (2015-06-16 23:02:08 UTC) #5
ncarter (slow)
lgtm
5 years, 6 months ago (2015-06-17 05:47:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189823003/1
5 years, 6 months ago (2015-06-17 10:54:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/77884)
5 years, 6 months ago (2015-06-17 12:09:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189823003/1
5 years, 6 months ago (2015-06-17 13:20:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 14:11:21 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 14:12:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1118ad1db53d8ec6be1f24afec3b03d96c01037
Cr-Commit-Position: refs/heads/master@{#334823}

Powered by Google App Engine
This is Rietveld 408576698