client/linux/minidump_writer/minidump_writer.cc - Issue 1189823002: Update breakpad for Android packed relocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/linux/minidump_writer/minidump_writer.cc

Issue 1189823002: Update breakpad for Android packed relocations. (Closed) Base URL: https://chromium.googlesource.com/external/google-breakpad/src.git@master

Patch Set: Update for more review comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/linux/minidump_writer/minidump_writer.cc

diff --git a/client/linux/minidump_writer/minidump_writer.cc b/client/linux/minidump_writer/minidump_writer.cc

index 0414bb72a7fd3874e74debe78d33ba0f0b4a9c61..9c1db99b81d180b2e71c1758ce3601aae8269e8e 100644

--- a/client/linux/minidump_writer/minidump_writer.cc

+++ b/client/linux/minidump_writer/minidump_writer.cc

@@ -154,7 +154,7 @@ class MinidumpWriter {

else if (!minidump_writer_.Open(path_))

return false;

- return dumper_->ThreadsSuspend();

+ return dumper_->ThreadsSuspend() && dumper_->LateInit();

}

~MinidumpWriter() {

« no previous file with comments | « client/linux/minidump_writer/linux_dumper.cc ('k') | common/linux/dump_symbols.cc » ('j') | no next file with comments »