Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1189753007: Move FontConfig factory into separate file. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move FontConfig factory into separate file. This moves the SkFontMgr::Factory implementation which creates a FontMgr around FontConfig into its own file, and allows the user to create one manually. Committed: https://skia.googlesource.com/skia/+/0b1de2626a289ab21bd3b93277ed34d022824b3d

Patch Set 1 #

Patch Set 2 : Add to ignored header list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M gyp/ports.gyp View 3 chunks +9 lines, -0 lines 0 comments Download
M gyp/tools.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A include/ports/SkFontMgr_fontconfig.h View 1 chunk +22 lines, -0 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
A + src/ports/SkFontMgr_fontconfig_factory.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bungeman-skia
I think this is the last of this sort of cleanup which can be made ...
5 years, 6 months ago (2015-06-16 20:55:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189753007/1
5 years, 6 months ago (2015-06-16 21:33:15 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/1577)
5 years, 6 months ago (2015-06-16 21:34:39 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189753007/20001
5 years, 6 months ago (2015-06-16 21:43:23 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 21:48:34 UTC) #10
reed1
header looks very clear. lgtm
5 years, 6 months ago (2015-06-17 14:52:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189753007/20001
5 years, 6 months ago (2015-06-17 14:55:28 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 14:56:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0b1de2626a289ab21bd3b93277ed34d022824b3d

Powered by Google App Engine
This is Rietveld 408576698