src/pattern-rewriter.cc - Issue 1189743003: [destructuring] Implement parameter pattern matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pattern-rewriter.cc

Issue 1189743003: [destructuring] Implement parameter pattern matching. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Done Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pattern-rewriter.cc

diff --git a/src/pattern-rewriter.cc b/src/pattern-rewriter.cc

index a487a10c3597fc51155827b2bacc2a37c050b4a7..6969cf214ed70034fce8f58a737724ab4b600700 100644

--- a/src/pattern-rewriter.cc

+++ b/src/pattern-rewriter.cc

@@ -53,7 +53,8 @@ void Parser::PatternRewriter::VisitVariableProxy(VariableProxy* pattern) {

Declaration* declaration = factory()->NewVariableDeclaration(

proxy, descriptor_->mode, descriptor_->scope,

descriptor_->declaration_pos);

- Variable* var = parser->Declare(declaration, descriptor_->mode != VAR, ok_);

+ Variable* var = parser->Declare(declaration, descriptor_->declaration_kind,

+ descriptor_->mode != VAR, ok_);

if (!*ok_) return;

DCHECK_NOT_NULL(var);

DCHECK(!proxy->is_resolved() || proxy->var() == var);