src/ia32/full-codegen-ia32.cc - Issue 1189743003: [destructuring] Implement parameter pattern matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 1189743003: [destructuring] Implement parameter pattern matching. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index f27dd21d5a13fbb541c472ebf1c5d31f4246570b..76634fa84a7248303def30c9d64f7bdef46b1567 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -208,7 +208,8 @@ void FullCodeGenerator::Generate() {

int num_parameters = info->scope()->num_parameters();

int first_parameter = info->scope()->has_this_declaration() ? -1 : 0;

for (int i = first_parameter; i < num_parameters; i++) {

- Variable* var = (i == -1) ? scope()->receiver() : scope()->parameter(i);

+ Variable* var =

+ (i == -1) ? scope()->receiver() : scope()->parameter_var(i);

if (var->IsContextSlot()) {

int parameter_offset = StandardFrameConstants::kCallerSPOffset +

(num_parameters - 1 - i) * kPointerSize;