Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1189703004: Reland: Build Mojo apps in sub-dirs, like application packages. (Closed)

Created:
5 years, 6 months ago by msw
Modified:
5 years, 6 months ago
Reviewers:
sky, scottmg
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Build Mojo apps in sub-dirs, like application packages. Reland https://codereview.chromium.org/1189703004/ Also fix ShellTestBase for mojo_runner_unittests, etc. Share and copy asset caching code used by ShellMain.java. Original description (still correct): Build Mojo apps in subdirectories, like application packages. Build all <foo>.mojo targets in a <foo> sub-directory. Support resources bundled in mojo_native_application. Remove mojo_application_package (now redundant). Update hard-coded paths and simplify URL resolution code. Remove apps bundled in core_services from Mandoline.apk (network service, surfaces service, view manager) This would help NetworkFetcher resolve app locations. (Android apptests host the build dir on a local server) (but apptests should instead bundle apps in an apk) BUG=498020 TEST=Mojo runner and Mandoline still work (as much as they currently do :-/) R=scottmg@chromium.org,sky@chromium.org Committed: https://crrev.com/0900ab2febde6e1a273bc7c187ba32d21b85bd84 Cr-Commit-Position: refs/heads/master@{#334547}

Patch Set 1 : Previously landed CL. #

Patch Set 2 : Fixing Android mojo_runner_unittests. #

Patch Set 3 : Cleanup, move getAssetsList to FileHelper; rename local to cached. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -274 lines) Patch
M components/html_viewer/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M components/resource_provider/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 2 chunks +9 lines, -12 lines 0 comments Download
M mandoline/ui/browser/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/mojo_application_package.gni View 1 chunk +0 lines, -113 lines 0 comments Download
M mojo/public/mojo_application.gni View 7 chunks +36 lines, -21 lines 0 comments Download
M mojo/runner/BUILD.gn View 2 chunks +11 lines, -5 lines 0 comments Download
M mojo/runner/android/android_handler.cc View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/FileHelper.java View 1 2 3 chunks +40 lines, -0 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java View 1 2 5 chunks +8 lines, -41 lines 0 comments Download
M mojo/runner/android/tests/src/org/chromium/mojo/shell/ShellTestBase.java View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M mojo/runner/context.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/runner/url_resolver.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M mojo/runner/url_resolver_unittest.cc View 1 chunk +6 lines, -30 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
msw
Hey Scotts, please take a look; thanks!
5 years, 6 months ago (2015-06-16 01:12:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189703004/60001
5 years, 6 months ago (2015-06-16 01:13:34 UTC) #5
scottmg
lgtm
5 years, 6 months ago (2015-06-16 01:49:15 UTC) #6
sky
LGTM
5 years, 6 months ago (2015-06-16 02:44:25 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 02:51:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189703004/60001
5 years, 6 months ago (2015-06-16 03:05:29 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 6 months ago (2015-06-16 03:09:40 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/0900ab2febde6e1a273bc7c187ba32d21b85bd84 Cr-Commit-Position: refs/heads/master@{#334547}
5 years, 6 months ago (2015-06-16 03:10:23 UTC) #13
jam
This broke Mandoline on Windows, since ICU is looking for the .dat file in the ...
5 years, 6 months ago (2015-06-16 15:44:49 UTC) #14
msw
5 years, 6 months ago (2015-06-16 16:05:43 UTC) #15
Message was sent while issue was closed.
On 2015/06/16 15:44:49, jam wrote:
> This broke Mandoline on Windows, since ICU is looking for the .dat file in the
> subdirectories and they're not there.

Shoot, you can revert if you want, I'll look when I get in.

Powered by Google App Engine
This is Rietveld 408576698