Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1189683004: ifdef out ProcessUtilTest.CloneFlags on linux with old kernel headers (Closed)

Created:
5 years, 6 months ago by Mostyn Bramley-Moore
Modified:
5 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ifdef out ProcessUtilTest.CloneFlags on linux with old kernel headers This allows the rest of base_unittests to build/run on such systems. BUG=312380 Committed: https://crrev.com/3cf743a247fbd50936c0eaf395c2b1345813661b Cr-Commit-Position: refs/heads/master@{#335123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/process/process_util_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Mostyn Bramley-Moore
@Lei Zhang, rickyz: please take a look at this tiny fixup for linux targets with ...
5 years, 6 months ago (2015-06-18 10:21:35 UTC) #2
Lei Zhang
3.8 is relatively new. Let's do this and revisit it in a couple years.
5 years, 6 months ago (2015-06-18 18:42:33 UTC) #3
rickyz (no longer on Chrome)
On 2015/06/18 18:42:33, Lei Zhang wrote: > 3.8 is relatively new. Let's do this and ...
5 years, 6 months ago (2015-06-18 19:28:00 UTC) #4
Lei Zhang
lgtm
5 years, 6 months ago (2015-06-18 20:35:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1189683004/1
5 years, 6 months ago (2015-06-18 20:37:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 21:13:00 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 21:14:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cf743a247fbd50936c0eaf395c2b1345813661b
Cr-Commit-Position: refs/heads/master@{#335123}

Powered by Google App Engine
This is Rietveld 408576698