Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3070)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 11896113: Add chrome-search: access from Instant overlay (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Charlie's comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 0a28d0f0c00f5433041fbf7d1d05e903ae5ff555..3910e020fece63e3f60b1072df65fdba0009a5aa 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -246,13 +246,16 @@ void ChromeContentRendererClient::RenderThreadStarted() {
if (command_line->HasSwitch(switches::kEnableIPCFuzzing)) {
thread->GetChannel()->set_outgoing_message_filter(LoadExternalIPCFuzzer());
}
- // chrome:, chrome-devtools:, and chrome-internal: pages should not be
- // accessible by normal content, and should also be unable to script
- // anything but themselves (to help limit the damage that a corrupt
+ // chrome:, chrome-search:, chrome-devtools:, and chrome-internal: pages
+ // should not be accessible by normal content, and should also be unable to
+ // script anything but themselves (to help limit the damage that a corrupt
// page could cause).
WebString chrome_ui_scheme(ASCIIToUTF16(chrome::kChromeUIScheme));
WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(chrome_ui_scheme);
+ WebString chrome_search_scheme(ASCIIToUTF16(chrome::kChromeSearchScheme));
+ WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(chrome_search_scheme);
+
WebString dev_tools_scheme(ASCIIToUTF16(chrome::kChromeDevToolsScheme));
WebSecurityPolicy::registerURLSchemeAsDisplayIsolated(dev_tools_scheme);
@@ -264,14 +267,17 @@ void ChromeContentRendererClient::RenderThreadStarted() {
WebSecurityPolicy::registerURLSchemeAsLocal(drive_scheme);
#endif
- // chrome: pages should not be accessible by bookmarklets or javascript:
- // URLs typed in the omnibox.
+ // chrome: and chrome-search: pages should not be accessible by bookmarklets
+ // or javascript: URLs typed in the omnibox.
WebSecurityPolicy::registerURLSchemeAsNotAllowingJavascriptURLs(
chrome_ui_scheme);
+ WebSecurityPolicy::registerURLSchemeAsNotAllowingJavascriptURLs(
+ chrome_search_scheme);
- // chrome:, and chrome-extension: resources shouldn't trigger insecure
- // content warnings.
+ // chrome:, chrome-search:, and chrome-extension: resources shouldn't trigger
+ // insecure content warnings.
WebSecurityPolicy::registerURLSchemeAsSecure(chrome_ui_scheme);
+ WebSecurityPolicy::registerURLSchemeAsSecure(chrome_search_scheme);
WebString extension_scheme(ASCIIToUTF16(extensions::kExtensionScheme));
WebSecurityPolicy::registerURLSchemeAsSecure(extension_scheme);

Powered by Google App Engine
This is Rietveld 408576698