Add chrome-search: access from Instant overlay

chrome/browser/browser_process_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_process_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <set>
 #include <vector>
@@ skipping 165 matching lines @@
   // Must be created after the NotificationService.
   print_job_manager_.reset(new printing::PrintJobManager);
 #endif
 
   net_log_.reset(new ChromeNetLog);
 
   ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeScheme(
       extensions::kExtensionScheme);
   ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeScheme(
       chrome::kExtensionResourceScheme);
+  ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeScheme(
+      chrome::kChromeSearchScheme);

[Charlie Reis, 2013/03/02 04:41:09]

This means FilterURL won't complain if it sees chrome-search: requests from
normal renderer processes, I believe.  Is there somewhere else that we ensure
that only the Instant process can make those requests?

[dhollowa, 2013/03/04 18:39:35]

The cross-origin checks block this normally on the renderer side, and the
URLDataSource::ShouldServiceRequest will block these on the browser-side
normally.

For the Instant case, I use
WebKit::WebSecurityPolicy::addOriginAccessWhitelistEntry on the renderer side,
and permit specific data-source access via URLDataSource::ShouldAccessRequest on
the browser side.

Since those checks are in place, I needed to disable the
ChildProcessSecurityPolicy stuff here.

 
 #if defined(OS_MACOSX)
   InitIdleMonitor();
 #endif
 
   extension_event_router_forwarder_ = new extensions::EventRouterForwarder;
 
   ExtensionRendererState::GetInstance()->Init();
 }
 
@@ skipping 836 matching lines @@
 }
 
 void BrowserProcessImpl::OnAutoupdateTimer() {
   if (CanAutorestartForUpdate()) {
     DLOG(WARNING) << "Detected update.  Restarting browser.";
     RestartBackgroundInstance();
   }
 }
 
 #endif  // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)