Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 11896064: Fix corner case when JSFunction is evicted from flusher. (Closed)

Created:
7 years, 11 months ago by Michael Starzinger
Modified:
7 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix corner case when JSFunction is evicted from flusher. This fixes a corner case that happens when JSFunctions are enqueued as code flushing candidates but their respective SharedFunctionInfo isn't. If the JSFunction gets evicted due to optimization the code slot in the SharedFunctionInfo will never be recorded in the slots buffer. R=hpayer@chromium.org BUG=chromium:168801 TEST=cctest/test-heap/Regress168801 Committed: http://code.google.com/p/v8/source/detail?r=13481

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
M src/mark-compact.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +55 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 11 months ago (2013-01-23 15:42:43 UTC) #1
Hannes Payer (out of office)
LGTM with one comment. https://codereview.chromium.org/11896064/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/11896064/diff/1/test/cctest/test-heap.cc#newcode2796 test/cctest/test-heap.cc:2796: CompileRun("var x = 0;"); CompileRun ...
7 years, 11 months ago (2013-01-23 16:03:41 UTC) #2
Michael Starzinger
7 years, 11 months ago (2013-01-23 16:16:03 UTC) #3
Message was sent while issue was closed.
Landed.

https://codereview.chromium.org/11896064/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/11896064/diff/1/test/cctest/test-heap.cc#newc...
test/cctest/test-heap.cc:2796: CompileRun("var x = 0;");
On 2013/01/23 16:03:41, Hannes Payer wrote:
> CompileRun needed?

Done.

Powered by Google App Engine
This is Rietveld 408576698