Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 11896061: Prepare push to trunk. Now working on version 3.16.9. (Closed)

Created:
7 years, 11 months ago by mvstanton
Modified:
7 years, 11 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.16.9. R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13472

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M ChangeLog View 1 chunk +17 lines, -0 lines 4 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
7 years, 11 months ago (2013-01-23 13:31:10 UTC) #1
Yang
LGTM with a nit. https://codereview.chromium.org/11896061/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/11896061/diff/1/ChangeLog#newcode12 ChangeLog:12: Fix pattern detection for replacing ...
7 years, 11 months ago (2013-01-23 13:32:30 UTC) #2
mvstanton
Thanks! Fixed tense confusion... https://codereview.chromium.org/11896061/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/11896061/diff/1/ChangeLog#newcode12 ChangeLog:12: Fix pattern detection for replacing ...
7 years, 11 months ago (2013-01-23 13:35:01 UTC) #3
Jakob Kummerow
https://codereview.chromium.org/11896061/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/11896061/diff/1/ChangeLog#newcode13 ChangeLog:13: (Chromium issue 2499) Too late now, but this is ...
7 years, 11 months ago (2013-01-23 14:25:53 UTC) #4
Yang
7 years, 11 months ago (2013-01-23 14:27:32 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/11896061/diff/1/ChangeLog
File ChangeLog (right):

https://codereview.chromium.org/11896061/diff/1/ChangeLog#newcode13
ChangeLog:13: (Chromium issue 2499)
On 2013/01/23 14:25:53, Jakob wrote:
> Too late now, but this is in fact a V8 issue.

My bad. I should have noticed...

Powered by Google App Engine
This is Rietveld 408576698