Issue 11896050: [Android] Keep track of unknown test results at the TestRunner layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11896050: [Android] Keep track of unknown test results at the TestRunner layer. (Closed)

Created:
7 years, 11 months ago by frankf

Modified:
7 years, 11 months ago

Reviewers:
craigdh, Yaron, Isaac (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Keep track of unknown test results at the TestRunner layer. If the entire gtest run crashes/failes/times out, the tests that were not run are marked as 'unknown'. These tests are reported by GetAllBroken() and are retried by BaseTestSharder. Get rid of overall_* flags which are now redundant. BUG=171466 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178345

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -61 lines)			Patch
M	build/android/pylib/base/base_test_sharder.py	View	4 chunks	+10 lines, -7 lines	0 comments	Download
M	build/android/pylib/base/test_result.py	View	7 chunks	+11 lines, -33 lines	0 comments	Download
M	build/android/pylib/gtest/single_test_runner.py	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	build/android/pylib/gtest/test_package.py	View	5 chunks	+1 line, -9 lines	0 comments	Download
M	build/android/pylib/utils/flakiness_dashboard_results_uploader.py	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	build/android/run_tests.py	View	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Looks good.

lgtm.

Expand Messages | Collapse Messages